"Go to symbol" is not showing results unless full type name used (ish)

[ivanz]

vscode extension version 1.1.0

Given the code below the "Go to workspace symbol" doesn't behave as expected. The following searches yield non-optimal results:

• ServiceLookup - no results. Expect to see ISomeServiceLookup and SomeServiceLookup as result.
• SomeService - only SomeServiceLookup listed
• ssl - no results. Expect to see ISomeServiceLookup and SomeServiceLookup as result.

For comparison - the "Go to file" works in all of the above cases.

namespace Test
{
    public interface ISomeServiceLookup {  }
    public class SomeServiceLookup : ISomeServiceLookup { }
}

[akshita31]

dotnet --info
.NET Command Line Tools (2.1.2)

Product Information:
Version: 2.1.2
Commit SHA-1 hash: 5695315371

Runtime Environment:
OS Name: Windows
OS Version: 10.0.16299
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\2.1.2\

Microsoft .NET Core Shared Framework Host

Version : 2.0.3
Build : a9190d4a75f4a982ae4b4fa8d1a24526566c69df

VSCode Version : 1.19.0
C# Extension Version : 1.13.1

I am getting the expected results in the first two cases.
@ivanz Could you try updating the extension and checking?
@rchande For the third point do we expect to see ISomeServiceLookup and SomeServiceLookup on searching ssl ?

[filipw]

I am getting the expected results in the first two cases.

we added substring lookups only recently OmniSharp/omnisharp-roslyn#990 - this shipped in 1.13.0 of the extension https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.13.0

[akshita31]

@filipw What is the expected behavior in the ssl case ?

[DustinCampbell]

@akshita31: That won't work because we only added substring lookups. There's a lot of code in Roslyn that handles these lookups using efficient data structures. I think we'll probably want a new public API in Roslyn to make this entire feature better in OmniSharp.

[filipw]

This can be closed - ssl in this case will work since we switched to SymbolFinder.FindSourceDeclarationsWithPatternAsync and we have a nice fuzzy search now.
This feature shipped in OmniSharp 1.32.7