Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/constraints-cli] constraints implementation for install/update #4748

Merged

Conversation

vlada-shubina
Copy link
Member

Problem

#3107

Solution

Constraints implementation for install and update.
If the template package has the templates that may be restricted by constraint, the list of violated constraints is shown after install. This does not return error code.

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@vlada-shubina vlada-shubina requested a review from a team as a code owner May 17, 2022 12:24
@vlada-shubina
Copy link
Member Author

This PR is built on top of #4745 - it should be merged first.

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor log wording suggestion is all I have here. This one seemed pretty straightforward after the ground work in the prior PR.

@vlada-shubina vlada-shubina merged commit ec028c5 into dotnet:feature/constraints-cli May 23, 2022
@vlada-shubina vlada-shubina deleted the cli-install branch May 23, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants