Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt report should indicate which TFMs are being used #3308

Open
MichaelSimons opened this issue Mar 10, 2023 · 0 comments
Open

Prebuilt report should indicate which TFMs are being used #3308

MichaelSimons opened this issue Mar 10, 2023 · 0 comments
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball

Comments

@MichaelSimons
Copy link
Member

As part of the effort to eliminate building net4* TFMs in source build as well as the work to improve the SBRP tooling, it has been realized that SBRP contains a lot more TFMs than strictly necessary. This is undesirable for the following reasons:

  1. Increases the build time
  2. Requires additional targeting packs. Targeting packs are required to build these SBRP to prevent prebuilts. The conjecture is there are some targeting packs that exist just for the purpose of building SBRP.
  3. Increases the size of the repo (large)

The primary reason for this is that when an SBRP is needed, the generate tooling is run which generates the ref packs for a fairly broad subset of TFMs. Only a small subset of TFMs have been filtered out in the past.

Only the required minimum set of TFMs should be generated. To support this, the prebuilt reports should be updated to indicate which TFMs are being referenced from the prebuilts. These TFMs can then then be specified to the SBRP tooling as the set to generate (passing in a set of TFMs to generate is already supported).

@dotnet-issue-labeler dotnet-issue-labeler bot added area-prebuilts Reducing the number of prebuilt packages in the tarball untriaged labels Mar 10, 2023
@MichaelSimons MichaelSimons moved this to 8.0 Preview 3 in .NET Source Build Mar 10, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Preview 3 to 8.0 Backlog in .NET Source Build Mar 10, 2023
@MichaelSimons MichaelSimons moved this from Needs Review to Backlog in .NET Source Build Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball
Projects
Status: Backlog
Development

No branches or pull requests

1 participant