Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use targeting packs to build net4xx rather than removing from TargetFrameworks using patches #1650

Closed
dagood opened this issue Jul 9, 2020 · 3 comments
Closed

Use targeting packs to build net4xx rather than removing from TargetFrameworks using patches #1650

dagood opened this issue Jul 9, 2020 · 3 comments
Labels
area-patch-removal Removing patches for contributing repos from source-build area-product-experience Improvements in the end-user's product experience

Comments

@dagood
Copy link
Member

dagood commented Jul 9, 2020

Currently there are patches in various repos to stop building net4xx target frameworks.

https://github.com/dotnet/source-build/blob/master/patches/roslyn/0001-Conditionally-remove-net472-from-TargetFrameworks.patch
https://github.com/dotnet/source-build/blob/master/patches/arcade/0006-Don-t-build-for-net472-when-building-from-source.patch
...

I think we can use the SBRP-built microsoft.netframework.referenceassemblies.net472/1.0.0-preview.2 to build this target framework as normal. This should remove a persistent source of patches across many repos if we can do this.
@dagood dagood added the area-patch-removal Removing patches for contributing repos from source-build label Jul 9, 2020
@dagood dagood mentioned this issue Jul 9, 2020
Merged
@dseefeld
Copy link
Contributor

Some repos assume that source-build means to not build for .NET Framework.

@dagood dagood mentioned this issue Oct 6, 2020
Closed
@dagood
Copy link
Member Author

dagood commented Oct 6, 2020

This also breaks OmniSharp because it tries to load build tasks on .NET Framework with Mono.

@dagood dagood added the area-product-experience Improvements in the end-user's product experience label Oct 6, 2020
@dagood dagood mentioned this issue Oct 12, 2020
Closed
@dagood dagood mentioned this issue Oct 28, 2020
Closed
@MichaelSimons MichaelSimons reopened this Jun 21, 2021
@MichaelSimons
Copy link
Member

Removal of Net4* targeting is being tracked with #3014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-patch-removal Removing patches for contributing repos from source-build area-product-experience Improvements in the end-user's product experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dseefeld @MichaelSimons @dagood