Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/msbuild #41106

Merged
merged 1 commit into from
May 24, 2024
Merged

[main] Update dependencies from dotnet/msbuild #41106

merged 1 commit into from
May 24, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: 51256791-e30b-4b96-f2b9-08daf1d75f3f
  • Build: 20240523.1
  • Date Produced: May 23, 2024 7:42:00 AM UTC
  • Commit: 147ecadd19ae031d5a511ad55908cff9bcdc17c5
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
e56e7b4 
…0523.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.11.0-preview-24271-01 -> To Version 17.11.0-preview-24273-01
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels May 23, 2024
@marcpopMSFT
Copy link
Member

The test failure looks like a known dotnet watch test timeout.

@dotnet/product-construction The vmr leg failure is strange and doesn't seem like it'd be related to the msbuild flow:

D:\a\_work\1\vmr\repo-projects\Directory.Build.targets(477,5): error : Repository asset manifest files don't exist. [D:\a\_work\1\vmr\repo-projects\fsharp.proj]
##[error]repo-projects\Directory.Build.targets(477,5): error : Repository asset manifest files don't exist.

@ViktorHofer
Copy link
Member

ViktorHofer commented May 23, 2024 •
edited
Loading

Looking at the pipeline artifact's fsharp.log, this means two things:

  1. The fsharp repo build failed and
  2. The fsharp repo build exit code doesn't correctly propagate back to the VMR orchestrator.

The fsharp repo build failure isn't that interesting:

Downloading vswhere
Stream was not readable.
System.ArgumentException: Stream was not readable.
   at System.IO.StreamReader..ctor(Stream stream, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize, Boolean leaveOpen)
   at System.IO.StreamReader..ctor(Stream stream, Encoding encoding)
   at Microsoft.PowerShell.Commands.FileSystemContentReaderWriter.CreateStreams(String filePath, String streamName, FileMode fileMode, FileAccess fileAccess, FileShare fileShare, Encoding fileEncoding)
   at Microsoft.PowerShell.Commands.FileSystemProvider.GetContentWriter(String path)
at EnablePreviewSdks, D:\a\_work\1\vmr\src\fsharp\eng\build.ps1: line 504
at <ScriptBlock>, D:\a\_work\1\vmr\src\fsharp\eng\build.ps1: line 531
at <ScriptBlock>, <No file>: line 1
at <ScriptBlock>, <No file>: line 1
##vso[task.logissue type=error](NETCORE_ENGINEERING_TELEMETRY=Build) Failure preparing build

The failing leg can be retried. Filed dotnet/source-build#4424 for the exit code propagation issue.

@ViktorHofer ViktorHofer mentioned this pull request May 23, 2024
Open
@v-wuzhai v-wuzhai merged commit 5cd4505 into main May 24, 2024
40 checks passed
@v-wuzhai v-wuzhai deleted the darc-main-e24ed759-8df8-4173-9cfe-792421eae693 branch May 24, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-wuzhai v-wuzhai v-wuzhai approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcpopMSFT @ViktorHofer @v-wuzhai