Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Enable running libraries and functional tests locally and on CI #93447

Open
2 tasks
Tracked by #84254
ivanpovazan opened this issue Oct 13, 2023 · 3 comments
Open
2 tasks
Tracked by #84254
Assignees
Milestone

Comments

@ivanpovazan
Copy link
Member

ivanpovazan commented Oct 13, 2023

Description

  1. Currently we run libraries and functional tests on CI only for ios-arm64 and tvos-arm64 platforms.
    In order to improve test coverage we should enable testing on:

    • maccatalyst
    • iossimulators
    • tvossimulators
  2. Additionally, running libraries and functional tests locally is currently not supported (on CI we build on Helix).
    Building the test project with:

    ./dotnet.sh build /t:Test -c Debug /p:TargetOS=ios /p:TargetArchitecture=arm64 src/tests/FunctionalTests/iOS/Device/AOT/iOS.Device.Aot.Test.csproj /p:UseNativeAOTRuntime=true /p:RunAOTCompilation=false /p:RuntimeFlavor=CoreCLR
    

    Fails with:

    /Users/ivan/repos/runtime-naot/src/mono/msbuild/apple/build/AppleBuild.targets(279,11): error MSB4057: The target "SetupProperties" does not exist in the project. [/Users/ivan/repos/runtime-naot/src/tests/FunctionalTests/iOS/Device/AOT/iOS.Device.Aot.Test.csproj]
    

Tasks

  • Enable running libraries and functional tests on CI for maccatalyst, iossimulators and tvossimulators with NativeAOT
  • Enable building/running libraries and functional tests locally for all iOS-like platforms with NativeAOT

NOTE: Linking relevant changes needed to run a functional test locally: https://github.com/dotnet/runtime/pull/93658/files#diff-0360540626912334f1c240468f218cbeb3966bbbc7d809fdbac435b1b5e3a95eR34-R53

@ghost
Copy link

ghost commented Oct 13, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

We currently do not run libraries and functional tests on CI with NativeAOT targeting maccatalyst, iossimulators and tvossimulators.
In order to improve test coverage we should enable testing on these platforms as well.

Author: ivanpovazan
Assignees: kotlarmilos
Labels:

os-ios, area-NativeAOT-coreclr

Milestone: 9.0.0

@ivanpovazan ivanpovazan changed the title [NativeAOT] Enable running libraries and functional tests on CI for maccatalyst and ios/tvos simulators [NativeAOT] Enable running libraries and functional tests locally and on CI for maccatalyst and ios/tvos simulators Oct 18, 2023
@ivanpovazan ivanpovazan changed the title [NativeAOT] Enable running libraries and functional tests locally and on CI for maccatalyst and ios/tvos simulators [NativeAOT] Enable running libraries and functional tests locally and on CI Oct 18, 2023
@kotlarmilos
Copy link
Member

Depends on #91871.

@kotlarmilos
Copy link
Member

Related to #81075.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants