Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure localization changes are ported to release/8.0 #90755

Closed
ericstj opened this issue Aug 17, 2023 · 3 comments · Fixed by #90812
Closed

Ensure localization changes are ported to release/8.0 #90755

ericstj opened this issue Aug 17, 2023 · 3 comments · Fixed by #90812

Comments

@ericstj
Copy link
Member

ericstj commented Aug 17, 2023

I believe our localization process feeds changes back into main and not release branches. I think we'll need to port these PRs as appropriate to release/8.0.

I'd be curious how other dotnet repos handle this to see if we can follow their lead. @wtgodbe any learnings from aspnetcore?

@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

I believe our localization process feeds changes back into main and not release branches. I think we'll need to port these PRs as appropriate to re release/8.0.

I'd be curious how other dotnet repos handle this to see if we can follow their lead. @wtgodbe any learnings from aspnetcore?

Author: ericstj
Assignees: -
Labels:

area-Infrastructure-libraries, blocking-release

Milestone: 8.0.0

@ericstj
Copy link
Member Author

ericstj commented Aug 17, 2023

@cristianosuzuki77 pointed me to some good docs on this. https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches shows how to enable loc for our release branch.

We should do this for release/8.0 (and make that a regular thing when we do these snaps during RC moving forward).

@carlossanlop can you please pick this up?

Note: this may be blocked by #90466 if the same break is present in release/8.0.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 18, 2023

I'd be curious how other dotnet repos handle this to see if we can follow their lead. @wtgodbe any learnings from aspnetcore?

We don't have a strict process for this either, we do manual backports as necessary. I wouldn't be surprised if we were missing some loc changes in release branches because of this - thanks for bringing this to my attention

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 18, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants