-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The working directory log message on app startup #85809
Comments
Tagging subscribers to this area: @dotnet/area-extensions-hosting Issue DetailsDescription#82445 added a new log message when an app starts. This is a very prominent place for logging (i.e. every ASP.NET Core app displays it by default when it starts) and it seems like it needs more work.
Reproduction StepsStart an app with hosting, e.g. an aspnetcore app, with console logging. The log is written to the console: Expected behaviorLog message is consistent with other logs on startup. Working directory is easy to understand. Actual behavior
Hosting environment and content root path logs have the format Also, this log seems the wrong place to add extra detail like "If Content root path is not set explicitly, then working directory is used by default.". It's visible by default in every ASP.NET Core app that starts up. Only the most important detail should be logged here. Regression?No response Known WorkaroundsNo response ConfigurationNo response Other informationNo response
|
I think we should revert this. It's unclear why this is useful information to show all of the time. |
Let's have another look at this, @steveharter. CC @pedrobsaila |
The commit was reverted and the original issue was reopened. |
Description
#82445 added a new log message when an app starts (last line):
This is a very prominent place for logging. Every ASP.NET Core app displays this log message by default when it starts. Exact thought needs to be put into what is logged here and it seems like it needs more work.
/
mean? Should this be a full path?Information
. If this is only useful for debugging then perhaps theDebug
log level would be better. That reduces logs written on app start.Reproduction Steps
Start an app with hosting, e.g. an aspnetcore app, with console logging. The log is written to the console:
Expected behavior
Log message is consistent with other logs on startup. Working directory value is easy to understand.
Actual behavior
Hosting environment and content root path logs have the format
Name: value
. I would expect the current working directory to be the same, e.g.Working directory: XXX
.Also, this log seems the wrong place to add extra detail like
If Content root path is not set explicitly, then working directory is used by default.
. This logging is visible by default in every ASP.NET Core app that starts up. Only the most important detail should be logged here. I don't think that sentence meets the bar.Regression?
No response
Known Workarounds
No response
Configuration
No response
Other information
No response
The text was updated successfully, but these errors were encountered: