Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64: Regressions in System.Tests.Perf_Random #69559

Closed
performanceautofiler bot opened this issue May 19, 2022 · 5 comments
Closed

Arm64: Regressions in System.Tests.Perf_Random #69559

performanceautofiler bot opened this issue May 19, 2022 · 5 comments
Assignees
@kunalspathak
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
7.0.0

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS ubuntu 18.04
Baseline 130ef3cae8b88593cbd1627d31c2c4bbf6336c40
Compare 35e47797a36e29475d28af61f0fa0fb3bf067838
Diff Diff

Regressions in System.Tests.Perf_Random

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NextBytes_span_unseeded - Duration of single invocation 290.03 ns 322.66 ns 1.11 0.00 True
NextBytes_unseeded - Duration of single invocation 294.25 ns 326.54 ns 1.11 0.00 True

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Tests.Perf_Random*'

Payloads

Baseline
Compare

Histogram

System.Tests.Perf_Random.NextBytes_span_unseeded

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 322.6556835689924 > 304.54658476800495.
IsChangePoint: Marked as a change because one of 5/11/2022 7:18:06 PM, 5/18/2022 4:10:31 AM falls between 5/9/2022 3:38:36 PM and 5/18/2022 4:10:31 AM.
IsRegressionStdDev: Marked as regression because -56.41038282341297 (T) = (0 -324.586755783676) / Math.Sqrt((3.4785271349660327 / (20)) + (4.713958925321555 / (26))) is less than -2.0153675744421933 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (26) - 2, .025) and -0.11555108925921106 = (290.96538823624826 - 324.586755783676) / 290.96538823624826 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

```#### System.Tests.Perf_Random.NextBytes_unseeded

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 326.53914957646003 > 307.44651144312525.
IsChangePoint: Marked as a change because one of 5/11/2022 7:18:06 PM, 5/18/2022 4:10:31 AM falls between 5/9/2022 3:38:36 PM and 5/18/2022 4:10:31 AM.
IsRegressionStdDev: Marked as regression because -29.950541233293794 (T) = (0 -330.0184077911277) / Math.Sqrt((14.833858155215703 / (20)) + (16.4387114696354 / (26))) is less than -2.0153675744421933 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (26) - 2, .025) and -0.11904148194466645 = (294.9116838972071 - 330.0184077911277) / 294.9116838972071 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arm64 untriaged New issue has not been triaged by the area owner labels May 19, 2022
@DrewScoggins DrewScoggins assigned EgorBo and unassigned dakersnar May 19, 2022
@kunalspathak kunalspathak changed the title [Perf] Changes at 5/12/2022 12:48:56 AM Arm64: Regressions in System.Tests.Perf_Random May 19, 2022
@kunalspathak kunalspathak assigned kunalspathak and unassigned EgorBo May 19, 2022
@kunalspathak
Copy link
Member

478b1b4...7b5f40f

@kunalspathak kunalspathak transferred this issue from dotnet/perf-autofiling-issues May 19, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 19, 2022
@ghost
Copy link

ghost commented May 19, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS ubuntu 18.04
Baseline 130ef3cae8b88593cbd1627d31c2c4bbf6336c40
Compare 35e47797a36e29475d28af61f0fa0fb3bf067838
Diff Diff

Regressions in System.Tests.Perf_Random

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NextBytes_span_unseeded - Duration of single invocation 290.03 ns 322.66 ns 1.11 0.00 True
NextBytes_unseeded - Duration of single invocation 294.25 ns 326.54 ns 1.11 0.00 True

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Tests.Perf_Random*'

Payloads

Baseline
Compare

Histogram

System.Tests.Perf_Random.NextBytes_span_unseeded

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 322.6556835689924 > 304.54658476800495.
IsChangePoint: Marked as a change because one of 5/11/2022 7:18:06 PM, 5/18/2022 4:10:31 AM falls between 5/9/2022 3:38:36 PM and 5/18/2022 4:10:31 AM.
IsRegressionStdDev: Marked as regression because -56.41038282341297 (T) = (0 -324.586755783676) / Math.Sqrt((3.4785271349660327 / (20)) + (4.713958925321555 / (26))) is less than -2.0153675744421933 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (26) - 2, .025) and -0.11555108925921106 = (290.96538823624826 - 324.586755783676) / 290.96538823624826 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

```#### System.Tests.Perf_Random.NextBytes_unseeded

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 326.53914957646003 > 307.44651144312525.
IsChangePoint: Marked as a change because one of 5/11/2022 7:18:06 PM, 5/18/2022 4:10:31 AM falls between 5/9/2022 3:38:36 PM and 5/18/2022 4:10:31 AM.
IsRegressionStdDev: Marked as regression because -29.950541233293794 (T) = (0 -330.0184077911277) / Math.Sqrt((14.833858155215703 / (20)) + (16.4387114696354 / (26))) is less than -2.0153675744421933 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (26) - 2, .025) and -0.11904148194466645 = (294.9116838972071 - 330.0184077911277) / 294.9116838972071 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: kunalspathak
Labels:

area-CodeGen-coreclr, untriaged, refs/heads/main, ubuntu 18.04, RunKind=micro, Regression, CoreClr, arm64
Milestone: -

@kunalspathak kunalspathak added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels May 19, 2022
@jeffschwMSFT
Copy link
Member

@kunalspathak based on the commit range, I think that area-codegen-coreclr is the most likely cause. What are your thoughts?

@kunalspathak kunalspathak added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 20, 2022
@ghost
Copy link

ghost commented May 20, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS ubuntu 18.04
Baseline 130ef3cae8b88593cbd1627d31c2c4bbf6336c40
Compare 35e47797a36e29475d28af61f0fa0fb3bf067838
Diff Diff

Regressions in System.Tests.Perf_Random

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NextBytes_span_unseeded - Duration of single invocation 290.03 ns 322.66 ns 1.11 0.00 True
NextBytes_unseeded - Duration of single invocation 294.25 ns 326.54 ns 1.11 0.00 True

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Tests.Perf_Random*'

Payloads

Baseline
Compare

Histogram

System.Tests.Perf_Random.NextBytes_span_unseeded

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 322.6556835689924 > 304.54658476800495.
IsChangePoint: Marked as a change because one of 5/11/2022 7:18:06 PM, 5/18/2022 4:10:31 AM falls between 5/9/2022 3:38:36 PM and 5/18/2022 4:10:31 AM.
IsRegressionStdDev: Marked as regression because -56.41038282341297 (T) = (0 -324.586755783676) / Math.Sqrt((3.4785271349660327 / (20)) + (4.713958925321555 / (26))) is less than -2.0153675744421933 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (26) - 2, .025) and -0.11555108925921106 = (290.96538823624826 - 324.586755783676) / 290.96538823624826 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

```#### System.Tests.Perf_Random.NextBytes_unseeded

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 326.53914957646003 > 307.44651144312525.
IsChangePoint: Marked as a change because one of 5/11/2022 7:18:06 PM, 5/18/2022 4:10:31 AM falls between 5/9/2022 3:38:36 PM and 5/18/2022 4:10:31 AM.
IsRegressionStdDev: Marked as regression because -29.950541233293794 (T) = (0 -330.0184077911277) / Math.Sqrt((14.833858155215703 / (20)) + (16.4387114696354 / (26))) is less than -2.0153675744421933 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (20) + (26) - 2, .025) and -0.11904148194466645 = (294.9116838972071 - 330.0184077911277) / 294.9116838972071 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: kunalspathak
Labels:

tenet-performance, tenet-performance-benchmarks, area-CodeGen-coreclr, untriaged, refs/heads/main, ubuntu 18.04, RunKind=micro, Regression, CoreClr, arm64
Milestone: -

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label May 20, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone May 20, 2022
@kunalspathak
Copy link
Member

This was introduced in #71498 and fixed in #71673.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
@jeffhandley jeffhandley added runtime-coreclr specific to the CoreCLR runtime os-linux Linux OS (any supported distro) and removed CoreClr labels Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kunalspathak kunalspathak

Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
6 participants
@EgorBo @jeffhandley @jeffschwMSFT @kunalspathak @dakersnar @JulieLeeMSFT