Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Fix exception reason on evaluation of method that throws #69300

Closed
Tracked by #90587
ilonatommy opened this issue May 13, 2022 · 3 comments
Closed
Tracked by #90587
Assignees
Labels
arch-wasm WebAssembly architecture area-Debugger-mono enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@ilonatommy
Copy link
Member

ilonatommy commented May 13, 2022

In test: DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsError for case evaluating: this.ParmToTestObjException.MyMethod()

is failing because:

(2,43): error CS1061: 'string' does not contain a definition for 'MyMethod' and no accessible extension method 'MyMethod' accepting a first argument of type 'string' could be found (are you missing a u    sing directive or an assembly reference?)

but should fail because ParmToTestObjException threw an exception.

Script used to compile the expression:

string this_ParmToTestObjException_fee35 = "System.Exception: error2"; return (this_ParmToTestObjException_fee35.MyMethod() );

Suggested in: #66654 (comment)

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 13, 2022
@ghost
Copy link

ghost commented May 13, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ilonatommy
Assignees: -
Labels:

untriaged, area-Debugger-mono

Milestone: -

@ilonatommy ilonatommy changed the title [wasm][debugger [wasm][debugger] Fix exception reason on evaluation of method that throws May 13, 2022
@ilonatommy ilonatommy self-assigned this May 13, 2022
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture and removed untriaged New issue has not been triaged by the area owner labels May 13, 2022
@ghost
Copy link

ghost commented May 13, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In test: DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsError for case evaluating: this.ParmToTestObjException.MyMethod()

is failing because:

(2,43): error CS1061: 'string' does not contain a definition for 'MyMethod' and no accessible extension method 'MyMethod' accepting a first argument of type 'string' could be found (are you missing a u    sing directive or an assembly reference?)

but should fail because ParmToTestObjException threw an exception.

Script used to compile the expression:

string this_ParmToTestObjException_fee35 = "System.Exception: error2"; return (this_ParmToTestObjException_fee35.MyMethod() );
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@thaystg thaystg added this to the 7.0.0 milestone Jul 5, 2022
@ilonatommy ilonatommy modified the milestones: 7.0.0, 8.0.0 Aug 11, 2022
@lewing lewing modified the milestones: 8.0.0, 9.0.0 Jul 24, 2023
@lewing lewing assigned thaystg and unassigned ilonatommy Feb 21, 2024
@thaystg thaystg added the enhancement Product code improvement that does NOT require public API changes/additions label Mar 4, 2024
@lewing lewing modified the milestones: 9.0.0, Future Apr 26, 2024
@thaystg
Copy link
Member

thaystg commented Aug 6, 2024

This is fixed by the new debugger.

@thaystg thaystg closed this as completed Aug 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

3 participants