Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties for arrays, strings and other System classes #66823

Closed
ilonatommy opened this issue Mar 18, 2022 · 2 comments
Closed

Add properties for arrays, strings and other System classes #66823

ilonatommy opened this issue Mar 18, 2022 · 2 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Milestone

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Mar 18, 2022

Array, string and e.g. Type have properties that are not supported in the debugger:

  • int_arr.Length;
  • str[0];
  • some_type.FullName;

Beyond typical tests add null-condition checking tests, something of this kind:

[ConditionalFact(nameof(RunningOnChrome))]
public async Task EvaluateNullPrimitivePropertiesPositive() => await CheckInspectLocalsAtBreakpointSite(
     $"DebuggerTests.EvaluateNullableProperties", "Evaluate", 11, "Evaluate",
     $"window.setTimeout(function() {{ invoke_static_method ('[debugger-test] DebuggerTests.EvaluateNullableProperties:Evaluate'); 1 }})",
     wait_for_event_fn: async (pause_location) =>
     {
            var id = pause_location["callFrames"][0]["callFrameId"].Value<string>();
            await EvaluateOnCallFrameAndCheck(id,
                   ("str.Length", TNumber(9))
                   ("str?.Length", TNumber(9)),
                   ("str!.Length", TNumber(9)),
                   ("str_null?.Length", TObject("string", is_null: true)),
                   ("str_null!.Length", TObject("string", is_null: true))
            );
    });
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Mar 18, 2022
@ghost
Copy link

ghost commented Mar 18, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Array, string and e.g. Type have properties that are not supported in the debugger:

  • int_arr.Length;
  • str[0];
  • some_type.FullName;
Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@ilonatommy
Copy link
Member Author

Evaluation of propertie was solved in #67028 and null-conditional expressionsis a duplicate of: #69640.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

No branches or pull requests

2 participants