[Perf] Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Common

[DrewScoggins]

Run Information

Architecture	x64
OS	Windows 10.0.18362
Baseline	96ce6b35359b3c159ef3e685dd67cf30bb46769b
Compare	c5edf0e09541e2c9c4441c0abdf23f712507596c
Diff	Diff

Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Common

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
OneNodeBacktracking - Duration of single invocation	1.78 μs	2.23 μs	1.25	0.02	False
CtorInvoke - Duration of single invocation	138.34 μs	154.34 μs	1.12	0.00	False
Date_IsMatch - Duration of single invocation	79.03 ns	87.87 ns	1.11	0.03	False
Ctor - Duration of single invocation	29.66 μs	34.19 μs	1.15	0.03	False

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Common*'

Payloads

Baseline
Compare

Histogram

System.Text.RegularExpressions.Tests.Perf_Regex_Common.OneNodeBacktracking(Options: Compiled)

System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke(Options: Compiled)

System.Text.RegularExpressions.Tests.Perf_Regex_Common.Date_IsMatch(Options: Compiled)

System.Text.RegularExpressions.Tests.Perf_Regex_Common.Ctor(Options: Compiled)

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

[ghost]

Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run Information

Architecture	x64
OS	Windows 10.0.18362
Baseline	96ce6b35359b3c159ef3e685dd67cf30bb46769b
Compare	c5edf0e09541e2c9c4441c0abdf23f712507596c
Diff	Diff

Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Common

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
OneNodeBacktracking - Duration of single invocation	1.78 μs	2.23 μs	1.25	0.02	False
CtorInvoke - Duration of single invocation	138.34 μs	154.34 μs	1.12	0.00	False
Date_IsMatch - Duration of single invocation	79.03 ns	87.87 ns	1.11	0.03	False
Ctor - Duration of single invocation	29.66 μs	34.19 μs	1.15	0.03	False

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Common*'

Payloads

Baseline
Compare

Histogram

System.Text.RegularExpressions.Tests.Perf_Regex_Common.OneNodeBacktracking(Options: Compiled)

System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke(Options: Compiled)

System.Text.RegularExpressions.Tests.Perf_Regex_Common.Date_IsMatch(Options: Compiled)

System.Text.RegularExpressions.Tests.Perf_Regex_Common.Ctor(Options: Compiled)

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author:	DrewScoggins
Assignees:	-
Labels:	arch-x64, area-System.Text.RegularExpressions, os-windows, tenet-performance, tenet-performance-benchmarks, untriaged
Milestone:	-

[DrewScoggins]

Seems related to #51508

[DrewScoggins]

Improvements from this change:

Run Information

Architecture	x64
OS	Windows 10.0.18362
Baseline	96ce6b35359b3c159ef3e685dd67cf30bb46769b
Compare	c5edf0e09541e2c9c4441c0abdf23f712507596c
Diff	Diff

Improvemnts in System.Text.RegularExpressions.Tests.Perf_Regex_Common

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
Backtracking - Duration of single invocation	1.85 μs	268.47 ns	0.15	0.03	True
Backtracking - Duration of single invocation	471.42 ns	176.56 ns	0.37	0.01	True

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Common*'

Payloads

Baseline
Compare

Histogram

System.Text.RegularExpressions.Tests.Perf_Regex_Common.Backtracking(Options: None)

System.Text.RegularExpressions.Tests.Perf_Regex_Common.Backtracking(Options: Compiled)

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

[stephentoub]

cc: @pgovind

[pgovind]

Will look into this after #55960 (comment)

[stephentoub]

#51508 was reverted. Presumably/hopefully this will go away as well.

[pgovind]

Yup, we reverted #51508. I'd be very very surprised if the regressions/improvements here still remain. I'm going to close this issue for now. We can re-open if the regressions still exist.