Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] HandleWriteStartState should behave similarly to reading #55817

Closed
ManickaP opened this issue Jul 16, 2021 · 3 comments
Closed

[QUIC] HandleWriteStartState should behave similarly to reading #55817

ManickaP opened this issue Jul 16, 2021 · 3 comments
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Milestone
8.0.0

Comments

@ManickaP
Copy link
Member

ManickaP commented Jul 16, 2021 •
edited by karelz
Loading

The code flow should basically mirror reading code flow, which firstly handles state transitions inside the lock and then check and throw exceptions afterwards.

Source: Code review session
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Threading untriaged New issue has not been triaged by the area owner labels Jul 16, 2021
@ghost
Copy link

ghost commented Jul 16, 2021

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

The code flow should basically mirror reading code flow, which firstly handles state transitions inside the lock and then check and throw exceptions afterwards.

Author: ManickaP
Assignees: -
Labels:

area-System.Threading, untriaged
Milestone: -

@ManickaP ManickaP added area-System.Net.Quic and removed area-System.Threading untriaged New issue has not been triaged by the area owner labels Jul 16, 2021
@ghost
Copy link

ghost commented Jul 16, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

The code flow should basically mirror reading code flow, which firstly handles state transitions inside the lock and then check and throw exceptions afterwards.

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Quic
Milestone: -

@ManickaP ManickaP added this to the 7.0.0 milestone Jul 16, 2021
@ManickaP ManickaP mentioned this issue Jul 16, 2021
Closed
@CarnaViire CarnaViire mentioned this issue Aug 19, 2021
Merged
@karelz karelz added the enhancement Product code improvement that does NOT require public API changes/additions label Nov 16, 2021
@ManickaP ManickaP changed the title [QUIC] HandleWriteStartState should behave simiralrly to reading [QUIC] HandleWriteStartState should behave similarly to reading Feb 16, 2022
@rzikm rzikm self-assigned this May 18, 2022
@karelz karelz modified the milestones: 7.0.0, Future Jun 14, 2022
@ManickaP
Copy link
Member Author

Irrelevant now as this has completely changed in 7.0, closing.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2023
@karelz karelz modified the milestones: Future, 8.0.0 Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@karelz @ManickaP @rzikm