Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to change evaluate paths to accommodate shared code #55484

Open
hoyosjs opened this issue Jul 11, 2021 · 5 comments
Open

Need to change evaluate paths to accommodate shared code #55484

hoyosjs opened this issue Jul 11, 2021 · 5 comments

Comments

@hoyosjs
Copy link
Member

hoyosjs commented Jul 11, 2021

Today, #54954 was merged and it didn't run the Mono build and test legs. The official build broke as a consequence. The Mono DBI took a dependency on utilcode, sections of the PAL, and MD in coreclr. There's other places where there's a dependency like event pipe and portions of the host. We should check evaluate paths to ensure these changes test everything that's needed.

cc: @dotnet/runtime-infrastructure

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 11, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@hoyosjs hoyosjs added area-Infrastructure and removed untriaged New issue has not been triaged by the area owner labels Jul 11, 2021
@ghost
Copy link

ghost commented Jul 11, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Today, #54954 was merged and it didn't run the Mono build and test legs. The official build broke as a consequence. The Mono DBI took a dependency on utilcode, sections of the PAL, and MD in coreclr. There's other places where there's a dependency like event pipe and portions of the host. We should check evaluate paths to ensure these changes test everything that's needed.

cc: @dotnet/runtime-infrastructure

Author: hoyosjs
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@hoyosjs hoyosjs changed the title Need to change evaluate paths to accommodate shared code in between Mono and CoreCLR Need to change evaluate paths to accommodate shared code Jul 11, 2021
@safern safern added this to the 6.0.0 milestone Jul 12, 2021
@ViktorHofer
Copy link
Member

@akoeplinger didn't you recently fix that?

@akoeplinger
Copy link
Member

@ViktorHofer no, that was a different thing.

@ViktorHofer ViktorHofer modified the milestones: 6.0.0, 7.0.0 Aug 16, 2021
@SamMonoRT
Copy link
Member

Moving to 8.0.0, @akoeplinger @steveisok : something to consider soonish.

@SamMonoRT SamMonoRT modified the milestones: 7.0.0, 8.0.0 Aug 10, 2022
@agocke agocke modified the milestones: 8.0.0, 9.0.0 Sep 18, 2023
@agocke agocke modified the milestones: 9.0.0, 10.0.0 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants