Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document HttpResponseMessage.Dispose will terminate response and notify the server #54294

Closed
JamesNK opened this issue Jun 16, 2021 · 4 comments · Fixed by dotnet/dotnet-api-docs#6970
Assignees
Labels
area-System.Net.Http documentation Documentation bug or enhancement, does not impact product or test code
Milestone

Comments

@JamesNK
Copy link
Member

JamesNK commented Jun 16, 2021

HttpResponseMessage.Dispose() docs should mention that it will terminate a response early and send a notification to the server (e.g. HTTP/2 RST_STREAM).

https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpresponsemessage.dispose?view=net-5.0

@JamesNK JamesNK added documentation Documentation bug or enhancement, does not impact product or test code area-System.Net.Http labels Jun 16, 2021
@ghost
Copy link

ghost commented Jun 16, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

HttpResponseMessage.Dispose() docs should mention that it will terminate a response early and send a notification to the server (e.g. HTTP/2 RST_STREAM).

https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpresponsemessage.dispose?view=net-5.0

Author: JamesNK
Assignees: -
Labels:

area-System.Net.Http, documentation

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 16, 2021
@geoffkizer
Copy link
Contributor

I suppose we could do this, but it's sort of a low-level detail that is invisible to most people. And the behavior is version dependent.

Why does it matter? If a user disposes the HttpResponseMessage then they have indicated they don't care about the response anymore. Whether that actually cancels it on the wire or not seems like an implementation detail.

@karelz
Copy link
Member

karelz commented Jun 22, 2021

Triage: @JamesNK do you want to put up PR with the language change from email exchange?

@karelz
Copy link
Member

karelz commented Jun 24, 2021

Found it: "Disposing a response that is in-progress can signal to the server that the response is no longer needed. This signal is implementation/protocol dependent"

@karelz karelz removed needs more info untriaged New issue has not been triaged by the area owner labels Jun 24, 2021
@karelz karelz added this to the 6.0.0 milestone Jun 24, 2021
@alnikola alnikola self-assigned this Aug 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants