Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start dogfooding .NET 6 SDK/runtime in CI? #46960

Closed
sdmaclea opened this issue Jan 14, 2021 · 8 comments · Fixed by #48462
Closed

Start dogfooding .NET 6 SDK/runtime in CI? #46960

sdmaclea opened this issue Jan 14, 2021 · 8 comments · Fixed by #48462
Assignees
@ViktorHofer
Labels
area-Infrastructure untriaged New issue has not been triaged by the area owner
Milestone
6.0.0

Comments

@sdmaclea
Copy link
Contributor

sdmaclea commented Jan 14, 2021 •
edited
Loading

I was looking at global.json to see whether we were using a version of SDK which included a specific Apple Silicon fix. I noticed we are still building with the .NET 5 SDK.

We should move to .NET 6 SDK before we release .NET 6 preview1 IMHO.

@dotnet/runtime-infrastructure
@sdmaclea sdmaclea added this to the 6.0.0 milestone Jan 14, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

I was looking at global.json to see whether we were using a version of SDK which included a specific Apple Silicon fix. I noticed we are still building with the .NET 5 SDK.

We should move to .NET 6 SDK before we release preview1 IMHO.

@dotnet/runtime-infrastructure

Author: sdmaclea
Assignees: -
Labels:

area-Infrastructure
Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 14, 2021
@jkoritzinsky
Copy link
Member

Generally, we only bump the SDK we use in dotnet/runtime when we need a new feature for our build since moving to a dogfooding build causes slightly worse developer experience. So far we haven't needed that, so we haven't started dogfooding.

@sdmaclea
Copy link
Contributor Author

It is an interesting tradeoff "developer experience" vs test coverage. Building against the dogfood runtime & SDK provides a lot of great coverage. It helps us find issues earlier.

Maybe we could have rolling dogfood builds? Best of both worlds?

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jan 14, 2021 •
edited
Loading

Maybe a dogfooding PR (subscription) which never gets merged?

I may create a PR updating global.json to a recent .NET 6 SDK/runtime just to see if it work for other platforms (before seeing if it works on macos-arm64)

@ViktorHofer
Copy link
Member

Maybe a dogfooding PR (subscription) which never gets merged?

Yes, we talked about dogfooding new SDK builds regularly but not via checking into the master branch but via scheduled builds (ie rolling and official ones).

since moving to a dogfooding build causes slightly worse developer experience.

Reliability is yet another factor that plays into the decision of sticking with a publicly released 5.0 SDK as long as possible.

@ViktorHofer
Copy link
Member

cc @Anipik for the continuous SDK dogfooding.

@sdmaclea sdmaclea mentioned this issue Jan 20, 2021
Closed
@ViktorHofer ViktorHofer self-assigned this Feb 23, 2021
@ViktorHofer ViktorHofer mentioned this issue Feb 23, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 23, 2021
@ViktorHofer
Copy link
Member

Will be fixed with #48462.

@sdmaclea
Copy link
Contributor Author

Closing in favor of #48462

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
6.0.0
3 participants
@jkoritzinsky @ViktorHofer @sdmaclea