Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managed threadpool PR + Implicit Fallthrough warning broke the build #43697

Closed
jkoritzinsky opened this issue Oct 21, 2020 · 1 comment · Fixed by #43701
Closed

Managed threadpool PR + Implicit Fallthrough warning broke the build #43697

jkoritzinsky opened this issue Oct 21, 2020 · 1 comment · Fixed by #43701
Labels
area-Infrastructure-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' blocking-official-build blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs

Comments

@jkoritzinsky
Copy link
Member

@kouvel @janvorli It looks like the build broke from the combination of #43397 and #38225. Can one of the two of you fix this so master isn't broken?
@jkoritzinsky jkoritzinsky added area-Infrastructure-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' blocking-official-build blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs labels Oct 21, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Oct 21, 2020
@kouvel
Copy link
Member

kouvel commented Oct 21, 2020

Ah I guess they got crossed, I'll take a look

@jkoritzinsky jkoritzinsky removed the untriaged New issue has not been triaged by the area owner label Oct 21, 2020
@runfoapp runfoapp bot mentioned this issue Oct 21, 2020
Closed
@kouvel kouvel mentioned this issue Oct 21, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' blocking-official-build blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fallthrough cases in portable thread pool change kouvel/runtime
3 participants
@jkoritzinsky @kouvel @Dotnet-GitSync-Bot