-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developers want to be confident that their apps run successfully when trimmed to avoid debugging trimming related problems at runtime #43078
Comments
@eerhardt this would be the parent story for most of your v-team's work -- any sub work items can be children of this (they will appear in themes tree) or at least checkboxes in this or a child issue similar to what we did for Nullability annotations. When you are ready to can you please link such child items, etc so all necessary work is represented here or in its children? |
For the ILLink warnings burndown, I've created #45623 (which is linked above). It will be used to check off assemblies as we get them ILLink warning "clean". |
Changed priority to P0 to align with Xamarin needs |
@agocke I have marked this 'committed'. LMK if that's not correct but surely it is. There may be some of the child work items that are aspirational but we are committed to this story |
Is there a plan to make trimming feature available not only for self-contained deployments? |
@tomkaa what would be the scenario where you would like to use the trimming? |
@marek-safar For example: I am developing ASP.NET Core application which has some NuGet packages installed and use framework-dependent deployment model. Some of the assemblies from NuGet are only used as middleware for local debugging. I have these middleware registrations surrounded with |
Yup, I think this is ready to close. |
In 5.0 we introduced linker capability to warn about code and patterns which are not trimming safe. We will build on top of that feature to resolve all warnings in our core SDKs to allow developers to enable this linker capability for their code and 3rd party libraries to give them confidence that trimming does not alter their app behaviour unexpectedly.
We'll also work on further enhancing the warning user experience to give the developers feedback about potential problems in their app as early as possible.
The primary goal for .NET6 is to have all linker related warnings resolved for core SDKs for all workloads which use publish with trimming enabled by default. In particular following workloads
Work Items
Partner dependencies:
UnconditionalSuppressAttribute
Request: TreatUnconditionalSuppressMessageAttribute
likeSuppressMessageAttribute
roslyn#48885MaciOS
The text was updated successfully, but these errors were encountered: