Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate .props files in packages directories #37241

Closed
am11 opened this issue Jun 1, 2020 · 4 comments · Fixed by #37254
Closed

Duplicate .props files in packages directories #37241

am11 opened this issue Jun 1, 2020 · 4 comments · Fixed by #37254
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner

Comments

@am11
Copy link
Member

am11 commented Jun 1, 2020

For each platform, we are adding copy of these files with no visible difference:

src/coreclr/src/.nuget/Microsoft.NETCore.ILAsm/runtime.$(PlatformName).Microsoft.NETCore.ILAsm.props
src/coreclr/src/.nuget/Microsoft.NETCore.ILDAsm/runtime.$(PlatformName).Microsoft.NETCore.ILDAsm.props
src/coreclr/src/.nuget/Microsoft.NETCore.TestHost/runtime.$(PlatformName).Microsoft.NETCore.TestHost.props
src/installer/pkg/projects/Microsoft.NETCore.DotNetAppHost/runtime.$(PlatformName).Microsoft.NETCore.DotNetAppHost.props
src/installer/pkg/projects/Microsoft.NETCore.DotNetHost/runtime.$(PlatformName).Microsoft.NETCore.DotNetHost.props
src/installer/pkg/projects/Microsoft.NETCore.DotNetHostPolicy/runtime.$(PlatformName).Microsoft.NETCore.DotNetHostPolicy.props
src/installer/pkg/projects/Microsoft.NETCore.DotNetHostResolver/runtime.$(PlatformName).Microsoft.NETCore.DotNetHostResolver.props

@jkotas, @ericstj, is it possible to deduplicate these files? until someday when we may need to do platform-specific specialization (in which case we can probably just override the properties using Condition=.. attribute without a new file).

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Jun 1, 2020
@ghost
Copy link

ghost commented Jun 1, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@am11
Copy link
Member Author

am11 commented Jun 1, 2020

Noticed this when working on enabling cross-compilation on illumos and Solaris. After completing the task, i realized that majority of lines added are due to these props files, which is apparently just a noise for each (existing/upcoming) platform.

@jkotas
Copy link
Member

jkotas commented Jun 1, 2020

Delete the .props file and inline their content with the right conditions to the place they are included from?

@am11
Copy link
Member Author

am11 commented Jun 1, 2020

Yes, I was thinking something like that, just wasn't sure if something else in the (post-)packaging process is relying on the presence runtime.$(PlatformName).$(ProjectName).props files.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants