GenerateReferenceAssemblySource does not respect the CompatibilitSuppressions.xml

[carlossanlop]

As asked here: #112440 (comment)

When I ran the commands from this guide:

cd src/libraries/System.IO.Compression/src/
dotnet build /p:ApiCompatValidateAssemblies=false
dotnet msbuild /t:GenerateReferenceAssemblySource

A ZLibException was unexpectedly added to the ref file, even though it's explicitly excluded in the CompatibilitySuppressions.xml file of System.IO.Compression.

I do not know if the GenAPI Task is currently configured to know how to locate any CompatibilitySuppressions.xml file and determine which APIs to skip. But since the addition to the ref was unexpected, we should look into this.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

[ericstj]

The expectation is that they are different inputs. Here's an example of how to configure GenAPI to exclude those types

runtime/src/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj

Line 8 in f922c43

<GenAPIExcludeApiList>ReferenceAssemblyExclusions.txt</GenAPIExcludeApiList>

Might be nice if we had a single way to tell both tools not to look at the type, but redundancy here isn't necessarily a bad thing.

[carlossanlop]

Ah yes, you're right, the CompatibilitySuppressions.xml does not have the format required by ApiCompat/GenAPI with a list of fullname DocIDs.

I'll do what Tensors is doing then. Thanks.

[carlossanlop]

Fixed it in System.IO.Compression.csproj: https://github.com/dotnet/runtime/pull/112440/files#diff-a9e5b4d167cacb3259db3392fd54f9f1c8c96568e4c49e9e73fa99414079044f

Since this isn't really a bug, but a missing property in the csproj, I think this can be closed.