-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Linux/x64: Regressions in System.IO.Compression #105331
Comments
Tagging subscribers to this area: @dotnet/area-system-io-compression |
Other related regressions: |
Seems to be caused by: #104904. @carlossanlop. We are only seeing this regression on Linux. |
I don't know what changed. I also saw the results for arm64 Linux, they're really bad and conflict with what we got in this previous report with a ton of improvements: dotnet/perf-autofiling-issues#38280 |
The diff for the set of these regressions, which seems to be the same time as the arm64 ones, is: 0f2e63f...bbabbc9. The commit that jumps out the most is #104904 where it seems something is causing the behavior to match pre-zlib changes behavior. |
If you look at one of these charts you can see two improvements and two regressions back to old levels. The first regression was when the initial zlib change was reverted. The second reversion seems like an unexpected outcome from #104904 |
Yep, thanks. We confirmed it and we are working on a fix: #105352 |
@carlossanlop can this be resolved now that #105352 is merged? |
I think so, yes. If the issue is still happening, we will get a new issue opened by the perf lab. |
Run Information
Regressions in System.IO.Compression.ZLib
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
System.IO.Compression.ZLib.Compress(level: Optimal, file: "sum")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.ZLib.Decompress(level: Fastest, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.ZLib.Decompress(level: Fastest, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.ZLib.Compress(level: Fastest, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.ZLib.Compress(level: Optimal, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.ZLib.Compress(level: Fastest, file: "sum")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.ZLib.Compress(level: Optimal, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.ZLib.Decompress(level: Optimal, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.ZLib.Decompress(level: Optimal, file: "sum")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.ZLib.Decompress(level: Fastest, file: "sum")
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.IO.Compression.Gzip
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
System.IO.Compression.Gzip.Decompress(level: Fastest, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Gzip.Compress(level: Optimal, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Gzip.Decompress(level: Fastest, file: "sum")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Gzip.Compress(level: Fastest, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Gzip.Compress(level: Fastest, file: "sum")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Gzip.Decompress(level: Fastest, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Gzip.Decompress(level: Optimal, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Gzip.Compress(level: Optimal, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Gzip.Decompress(level: Optimal, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Gzip.Compress(level: Fastest, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.IO.Compression.Deflate
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
System.IO.Compression.Deflate.Decompress(level: Optimal, file: "sum")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Deflate.Decompress(level: Optimal, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Deflate.Compress(level: Fastest, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Deflate.Compress(level: Optimal, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Deflate.Compress(level: Fastest, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Deflate.Decompress(level: Fastest, file: "alice29.txt")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Deflate.Compress(level: Optimal, file: "sum")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Deflate.Decompress(level: Optimal, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Deflate.Compress(level: Fastest, file: "sum")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Deflate.Decompress(level: Fastest, file: "sum")
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.IO.Compression.Brotli
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
System.IO.Compression.Brotli.Compress_WithoutState(level: Optimal, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
System.IO.Compression.Brotli.Compress_WithState(level: Optimal, file: "TestDocument.pdf")
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: