Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Not all return buffers are marked with DNER when we get to regular promotion #104571

Open
jakobbotsch opened this issue Jul 8, 2024 · 1 comment
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@jakobbotsch
Copy link
Member

When we do not mark these with DNER before promotion it results in dependent promotion, instead of allowing physical promotion to handle them. One example of this seems to be Microsoft.CodeAnalysis.CSharp.Symbols.ParameterSymbol:Microsoft.Cci.IParameterTypeInformation.get_CustomModifiers in benchmarks.run_pgo. It seems to be a path that is related to GDV that ends up creating a call node with a return buffer that isn't marked DNER.

@jakobbotsch jakobbotsch self-assigned this Jul 8, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 8, 2024
@jakobbotsch jakobbotsch added this to the 10.0.0 milestone Jul 8, 2024
@dotnet-policy-service dotnet-policy-service bot added untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels Jul 8, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

No branches or pull requests

1 participant