From 7d58d72894965435a04c4e20636da9a3d02c4503 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang <16830051+mdh1418@users.noreply.github.com> Date: Fri, 3 Sep 2021 13:22:20 -0400 Subject: [PATCH] [libraries] Skip test suites crashing on CI for iOS/tvOS/MacCatalyst (#57208) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [MacCatalyst][Libraries] Reenable MacCatalyst x64 crashing test suites * [MacCatalyst][Libraries] Reenable MacCatalyst arm64 crashing test suites * Temporarily enable MacCatalyst arm64 lane * Readd consistently crashing suites to iOS tvOS MacCatalyst skips * Address crashes and PNSE failures on iOS MacCatalyst * Temporarily bump timeout for tvOS * fix typo * Skip more crashed suites * Undo temporary changes and Add ActiveIssue * Skip more crashing suites * Skip iOS.Simulator.Aot.Test flake on MacCatalyst CI * Add a couple crashing suites * Remove sample skip in tests.proj as it doesnt do anything * Add another flakey crashed test for MacCatalyst * Skip System.Xml.Xsl.XslCompiledTransformApi on MacCatalyst * Temporarily remove test suite skips and enable arm64 lanes and bump lane timeout to evaluate crashes * Reenable a test that was fixed * Update Microsoft.DotNet.Helix.Sdk Fixes an issue with mismatched dotnet SDK versions we're hitting in runtime-staging on mobile platforms (see https://github.com/dotnet/arcade/pull/7788) * [iOS] Skip ValidAccessLevelCombinations ReadWriteExecute for iOSSimulator arm64 * Skip failing test suites * Extend trampoline bump to iOS tvOS MacCatalyst * Fixup typo * Fix MonoAOTCompiler typo * Bump trampolines for osxlike lanes * Add active issues for failing tests * Remove ActiveIssue that was fixed * Add IsIanaIdTest skip * Bump trampolines even higher * Address feedback * Fix typo * Undo runtime-staging temporary changes and cleanup test skips * Fix path typo * Skip iOS sample * Add new activeIssue and skip flakey Android test crash * Skip functional tests crashing with exit code 0 Co-authored-by: Mitchell Hwang Co-authored-by: Alexander Köplinger --- .../tests/PhysicalFileProviderTests.cs | 3 +- .../tests/FileSystemWatcher.WaitForChanged.cs | 1 + .../tests/MemoryMappedViewAccessor.Tests.cs | 4 +- .../tests/MemoryMappedViewStream.Tests.cs | 4 +- .../tests/System/EnvironmentTests.cs | 7 +- .../tests/System/TimeZoneInfoTests.cs | 1 + src/libraries/tests.proj | 71 +++++-------------- .../AotCompilerTask/MonoAOTCompiler.props | 3 +- 8 files changed, 28 insertions(+), 66 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.FileProviders.Physical/tests/PhysicalFileProviderTests.cs b/src/libraries/Microsoft.Extensions.FileProviders.Physical/tests/PhysicalFileProviderTests.cs index 8f2b5691fa9f80..4aa57114fcdc69 100644 --- a/src/libraries/Microsoft.Extensions.FileProviders.Physical/tests/PhysicalFileProviderTests.cs +++ b/src/libraries/Microsoft.Extensions.FileProviders.Physical/tests/PhysicalFileProviderTests.cs @@ -137,7 +137,7 @@ public void PollingFileProviderShouldntConsumeINotifyInstances() } } } - + private void GetFileInfoReturnsNotFoundFileInfoForIllegalPathWithLeadingSlashes(string path) { using (var provider = new PhysicalFileProvider(Path.GetTempPath())) @@ -936,6 +936,7 @@ public void NoopChangeTokenForFilterThatNavigatesAboveRoot() [Fact] [ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/58584", TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS)] public void TokenForEmptyFilter() { using (var root = new DisposableFileSystem()) diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs index aec8019cdceb9d..cce5f54469f2dd 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs @@ -111,6 +111,7 @@ public void NonZeroTimeout_NoEvents_TimesOut(bool enabledBeforeWait) [InlineData(WatcherChangeTypes.Changed, false)] [InlineData(WatcherChangeTypes.Renamed, true)] [InlineData(WatcherChangeTypes.All, true)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/58418", typeof(PlatformDetection), nameof(PlatformDetection.IsMacCatalyst), nameof(PlatformDetection.IsArm64Process))] public void NonZeroTimeout_NoActivity_TimesOut(WatcherChangeTypes changeType, bool enabledBeforeWait) { using (var testDirectory = new TempDirectory(GetTestFilePath())) diff --git a/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewAccessor.Tests.cs b/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewAccessor.Tests.cs index 8f7e2fae576eb0..0c8517ca4affe8 100644 --- a/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewAccessor.Tests.cs +++ b/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewAccessor.Tests.cs @@ -91,10 +91,10 @@ public void ValidAccessLevelCombinations(MemoryMappedFileAccess mapAccess, Memor } catch (UnauthorizedAccessException) { - if ((OperatingSystem.IsMacOS() || OperatingSystem.IsMacCatalyst() || PlatformDetection.IsInContainer) && + if ((OperatingSystem.IsMacOS() || OperatingSystem.IsMacCatalyst() || OperatingSystem.IsIOS() || OperatingSystem.IsTvOS() || PlatformDetection.IsInContainer) && (viewAccess == MemoryMappedFileAccess.ReadExecute || viewAccess == MemoryMappedFileAccess.ReadWriteExecute)) { - // Containers and OSX with SIP enabled do not have execute permissions by default. + // Containers and OSXlike platforms with SIP enabled do not have execute permissions by default. throw new SkipTestException("Insufficient execute permission."); } diff --git a/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewStream.Tests.cs b/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewStream.Tests.cs index d77a24ae0ddfa6..a5340527df9011 100644 --- a/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewStream.Tests.cs +++ b/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedViewStream.Tests.cs @@ -91,10 +91,10 @@ public void ValidAccessLevelCombinations(MemoryMappedFileAccess mapAccess, Memor } catch (UnauthorizedAccessException) { - if ((OperatingSystem.IsMacOS() || OperatingSystem.IsMacCatalyst() || PlatformDetection.IsInContainer) && + if ((OperatingSystem.IsMacOS() || OperatingSystem.IsMacCatalyst() || OperatingSystem.IsIOS() || OperatingSystem.IsTvOS() || PlatformDetection.IsInContainer) && (viewAccess == MemoryMappedFileAccess.ReadExecute || viewAccess == MemoryMappedFileAccess.ReadWriteExecute)) { - // Containers and OSX with SIP enabled do not have execute permissions by default. + // Containers and OSXlike platforms with SIP enabled do not have execute permissions by default. throw new SkipTestException("Insufficient execute permission."); } diff --git a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs index 3eb65fdef00e02..63723f0117a099 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs @@ -346,11 +346,8 @@ public void GetFolderPath_Unix_PersonalIsHomeAndUserProfile() Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal)); Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments)); } - // tvOS effectively doesn't have a HOME - if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS) - { - Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile)); - } + + Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile)); } [Theory] diff --git a/src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs b/src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs index 832677cc22c7ee..e58108123e5db7 100644 --- a/src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs +++ b/src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs @@ -2660,6 +2660,7 @@ public static void IsIanaIdWithNotCacheTest() } [ConditionalFact(nameof(SupportIanaNamesConversion))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/58440", TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS)] public static void IsIanaIdTest() { bool expected = !s_isWindows; diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 0163890c3e23d2..554a410d6d8cfe 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -120,6 +120,7 @@ + @@ -145,68 +146,27 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + - - - - - + - - - - - - - - - - - - - - + + + @@ -303,8 +263,9 @@ - + + - + +