Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing quick fixes before members #7980

Closed
miloush opened this issue Jan 15, 2016 · 7 comments
Closed

Missing quick fixes before members #7980

miloush opened this issue Jan 15, 2016 · 7 comments
Labels
Area-Compilers Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone

Comments

@miloush
Copy link

miloush commented Jan 15, 2016

I finally managed to find a simple repro I believe:

  1. Create a new WPF application project.
  2. Go to MainWindow.xaml.cs.
  3. Type WebClient in front of MainWindow's constructor, like this:
public partial class MainWindow : Window
{
    WebClient|
    public MainWindow()
    {
        InitializeComponent();
    }
}

At this point, a quick fix for CS0246 should be offered to resolve WebClient (i.e. add using System.Net). Actual results: no quick fix (probably because CS0246 is not generated at all).

I am not sure what triggers the issue, the same thing in console application works and under certain circumstances in WPF projects too. Anyway, I believe the add using option was available at this point in previous versions.

@Pilchie
Copy link
Member

Pilchie commented Jan 15, 2016

Thanks for the report. It looks like this worked in VS2015 RTM, then was regressed in Update 1, but is now working again in internal builds. @CyrusNajmabadi Can you verify that we have good test coverage here?

@Pilchie Pilchie added this to the 1.2 milestone Jan 15, 2016
@CyrusNajmabadi
Copy link
Member

This is failing because of: #7536

We need to fix the issue that we don't get errors for incomplete members so that this works.

@Pilchie
Copy link
Member

Pilchie commented Jan 22, 2016

I could have sworn I saw this work with the latest bits...

@DustinCampbell
Copy link
Member

This is a regression that we shipped in Update 1. I get that we'd like a compiler fix for it with #7536, but that's been pushed to 2.0. Is there a fix we can make now to fix the regressed behavior and then drive for the right fix later?

@DustinCampbell DustinCampbell modified the milestones: 1.3, 1.2 Mar 9, 2016
@CyrusNajmabadi
Copy link
Member

ping @gafter This is the same issue. We don't report semantic errors on incomplete members.

@CyrusNajmabadi
Copy link
Member

Assigning to gafter as this involved binding incomplete members.

@gafter gafter modified the milestones: 2.0 (RC), 1.3 May 13, 2016
@gafter gafter modified the milestones: 2.1, 2.0 (RC) Jul 18, 2016
@jaredpar jaredpar added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Feb 15, 2017
@jaredpar jaredpar modified the milestones: 2.1, Unknown Feb 15, 2017
@gafter gafter removed their assignment Jul 2, 2020
@CyrusNajmabadi
Copy link
Member

This is working for me:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants