Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce StateKind.AttemptingToComplete for partial analysis state tracking #65330

Closed
mavasani opened this issue Nov 10, 2022 · 1 comment
Closed

Comments

@mavasani
Copy link
Contributor

    >analyzerState?.ResetToReadyState(); [](http://example.com/codeflow?start=20&length=35)

Is the following going to decrease/eliminate the chances of us failing to complete the event because another thread "hijacked" the state after this line?

We could introduce another state, called "AttemptingToComplete". Before executing TryMarkEventComplete, we don't reset the state to "ReadyToProcess", instead we change it to AttemptingToComplete. And only, if TryMarkEventComplete failed, we reset to "ReadyToProcess".

I am not sure if this is going to introduce too much complexity, or, perhaps, a race for completion between different threads.

Originally posted by @AlekseyTs in #65083 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 10, 2022
@mavasani mavasani self-assigned this Nov 10, 2022
@jasonmalinowski jasonmalinowski removed the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 15, 2022
@jasonmalinowski jasonmalinowski added this to the Backlog milestone Nov 15, 2022
@mavasani
Copy link
Contributor Author

This is no longer required as all analysis state tracking code was removed with #66750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants