MetadataAsSource should show scoped modifiers

[RikkiGibson]

Definitely think that MetadataAsSource should show scoped modifiers. At a glance it seems like it doesn't. See MemoryMarshal.CreateSpan. (The point of this method is to be unsafe and claim it doesn't capture the parameter when it really does.)

        //
        // Summary:
        //     Creates a new span over a portion of a regular managed object.
        //
        // Parameters:
        //   reference:
        //     A reference to data.
        //
        //   length:
        //     The number of T elements that reference contains.
        //
        // Type parameters:
        //   T:
        //     The type of the data items.
        //
        // Returns:
        //     A span.
        public static Span<T> CreateSpan<T>(ref T reference, int length);

[Youssef1313]

@RikkiGibson There doesn't seem to be completion for scoped. This should be a high priority

[Youssef1313]

Also we likely will want to handle scoped ref here:

roslyn/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/Extensions/ContextQuery/SyntaxTreeExtensions.cs

Lines 1769 to 1792 in 7a9b666

	// ref |
	// ref readonly |
	// for ( ref |
	// foreach ( ref | x
	if (token.Kind() is SyntaxKind.RefKeyword or SyntaxKind.ReadOnlyKeyword)
	{
	var parent = token.Parent;
	if (parent is (kind: SyntaxKind.RefType or SyntaxKind.RefExpression or SyntaxKind.LocalDeclarationStatement))
	{
	if (parent.IsParentKind(SyntaxKind.VariableDeclaration) &&
	parent.Parent?.Parent is (kind:
	SyntaxKind.LocalDeclarationStatement or
	SyntaxKind.ForStatement or
	SyntaxKind.ForEachVariableStatement))
	{
	return true;
	}
	if (parent.Parent is (kind: SyntaxKind.ForEachStatement or SyntaxKind.ForEachVariableStatement))
	{
	return true;
	}
	}
	}

and make sure use implicit vs explicit type works for scoped ref variables as well (in for loops, out arguments, local declarations).

[Youssef1313]

I'm working on completion.

[arunchndr]

@cston / @RikkiGibson is this still a 17.5 candidate?

[RikkiGibson]

Re-triaging this. Deleted the question about showing 'scoped out' for implicit 'scoped' in out parameters. I think we don't need to be more verbose than the language default in this case.

re: quick info generally, I'm honestly not sure whether/how to show the scoped modifier, particularly because I don't know how to show [UnscopedRef]. @dotnet/roslyn-ide ultimately has the say on what should be included in Quick Info, so tagging them for guidance.

Definitely think that MetadataAsSource should show scoped modifiers. At a glance it seems like it doesn't. See MemoryMarshal.CreateSpan. (The point of this method is to be unsafe and claim it doesn't capture the parameter when it really does.)

        //
        // Summary:
        //     Creates a new span over a portion of a regular managed object.
        //
        // Parameters:
        //   reference:
        //     A reference to data.
        //
        //   length:
        //     The number of T elements that reference contains.
        //
        // Type parameters:
        //   T:
        //     The type of the data items.
        //
        // Returns:
        //     A span.
        public static Span<T> CreateSpan<T>(ref T reference, int length);