Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract interface loses "ref readonly" on parameters and returns #22238

Closed
VSadov opened this issue Sep 21, 2017 · 1 comment
Closed

Extract interface loses "ref readonly" on parameters and returns #22238

VSadov opened this issue Sep 21, 2017 · 1 comment
Assignees
@OmarTawfik
Labels
Area-IDE Bug Feature - Readonly References Readonly References Language-C#
Milestone
15.5

Comments

@VSadov
Copy link
Member

VSadov commented Sep 21, 2017

parameters become an ordinary ref, returns become ordinary byval returns.
@VSadov VSadov mentioned this issue Sep 21, 2017
Merged
@jcouv jcouv added this to the 15.5 milestone Sep 21, 2017
@OmarTawfik
Copy link
Contributor

Root cause: classes in src/Workspaces/CSharp/Portable/CodeGeneration don't use compiler helpers to generate refness of signatures, but instead do independent checks. Need to look deeper into that.

@OmarTawfik OmarTawfik mentioned this issue Sep 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmarTawfik OmarTawfik

Labels
Area-IDE Bug Feature - Readonly References Readonly References Language-C#
Projects
None yet
Milestone
15.5
Development

No branches or pull requests
3 participants
@VSadov @jcouv @OmarTawfik