You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're using modreqs to prevent other/older compilers from consuming/extending ref-readonly symbols in a non-safe way.
There is already some tests being added on VB side to assert that behavior, but we need to write [WindowsOnly] tests that call the csc/vbc on the machine (the native compilers) and assert they exhibit the right behavior as well.
I'm not sure what is the value of writing such test automation. Shouldn't it be good enough to verify once (possibly against different versions of the compiler)? Those shipped compilers are not expected to change.
@jcouv manual verification was done. But I want to have this sort of automation in case a regression happened in the way the current version writes out modreqs. This is not a high-pri though.
We're using modreqs to prevent other/older compilers from consuming/extending ref-readonly symbols in a non-safe way.
There is already some tests being added on VB side to assert that behavior, but we need to write [WindowsOnly] tests that call the csc/vbc on the machine (the native compilers) and assert they exhibit the right behavior as well.
See #17287 for more details
The text was updated successfully, but these errors were encountered: