Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terminal Logger] Report final duration in hours/minutes/seconds when appropriate #8782

Open
Tracked by #8370
baronfel opened this issue May 19, 2023 · 1 comment
Open
Tracked by #8370
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Cost:S Work that requires one engineer up to 1 week triaged

Comments

@baronfel
Copy link
Member

baronfel commented May 19, 2023

One more question:

image

Will we fix this to show humanly readable duration - as in minutes:seconds?

Originally posted by @vitek-karas in #8781 (comment)

The answer of course is yes - we should adjust the 'static' displays to react to thresholds and report hours and minutes appropriately. This would cover the 'completed project' summaries and the final build summary, but not the 'live' trackers for each of the currently-building projects.

After 60 seconds we should switch to MM:ss format, and after 60 minutes we should switch to HH:MM:ss format.

@baronfel baronfel added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label May 19, 2023
@KalleOlaviNiemitalo
Copy link

I once made a service log its processing durations as hh:mm:ss and later regretted that because the durations would have been easier to use in subsequent calculations (percentages, averages) if they had been logged as total seconds.

With MSBuild though, this would be less of a problem, as the parent process (e.g. CI runner) can easily measure how soon the MSBuild process exits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Cost:S Work that requires one engineer up to 1 week triaged
Projects
None yet
Development

No branches or pull requests

4 participants