[Feature Request]: Update VSCode Problem Matcher for MSBuild compilation errors to account for TerminalLogger formatting

[baronfel]

Summary

The VSCode problem matcher (seen here) doesn't understand the new formatting from the TerminalLogger. We should contribute a fix for this regex to understand the new sigils from the TerminalLogger.

Background and Motivation

Parity and not breaking existing VSCode tasks that use the $msCompile matcher.

Proposed Feature

We should update the regex that VSCode ships with the regex from this simple task test harness (the regexp specifically):

{
        "label": "build codebase",
        "command": "dotnet",
        "args": [
          "build", "/tl"
        ],
        "type": "shell",
        "problemMatcher": [
          {
            "owner": "dotnet",
            "source": "msbuild",
            "pattern": {
              "regexp": "^(?:\\s+[❌︎|⚠|🛈]*\\s+)(?:\\d+>)?(\\S.*)\\((\\d+|\\d+,\\d+|\\d+,\\d+,\\d+,\\d+)\\)\\s*:\\s+(error|warning|info)\\s+(\\w+\\d+)\\s*:\\s*(.*)$",
              "kind": "location",
              "file": 1,
              "location": 2,
              "severity": 3,
              "code": 4,
              "message": 5,
              }
            }
        ],
        "group": "build",
        "presentation": {
          "echo": true,
          "reveal": "always",
          "revealProblems": "onProblem",
          "focus": false,
          "panel": "shared",
          "showReuseMessage": false,
          "clear": true
        }
      }

Alternative Designs

• drop the sigil and keep compatibility with the existing problem matcher regex

[rainersigwald]

I would like to also consider dropping the sigil and matching the existing regexen. I like the visibility of the sigil but I wonder if we can get that in a less intrusive way.

[baronfel]

Noted! I added that as an alternative design to the suggestion.

[baronfel]

We are going to revert the emoji for p6 and instead colorize only the diagnostic prefix (ie 'Warning' or 'Error') and the diagnostic code. The message text should remain the current terminal foreground color.