Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LiveLogger] Disambiguate restore operation from build, when run in -restore mode #8435

Closed
Tracked by #8370
rainersigwald opened this issue Feb 9, 2023 · 1 comment
Closed
Tracked by #8370

[LiveLogger] Disambiguate restore operation from build, when run in -restore mode #8435

rainersigwald opened this issue Feb 9, 2023 · 1 comment
Labels
Area: Logging Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged

Comments

@rainersigwald
Copy link
Member

rainersigwald commented Feb 9, 2023 •
edited
Loading

When MSBuild is run with -restore there are two distinct build phases:

  1. Run the Restore target
  2. Run the default target (or target specified on the command line)

Either can create many project build requests, and have progress.

It'd be nice if the logger knew when restore was happening and didn't give a misleading progress indicator ("90% of projects 'built' for restore" is very distinct from "the overall build is 90% complete").
@rainersigwald rainersigwald mentioned this issue Feb 9, 2023
Open
28 tasks
@rainersigwald rainersigwald changed the title Disambiguate restore operation from build, when run in -restore mode [LiveLogger] Disambiguate restore operation from build, when run in -restore mode Feb 9, 2023
@ladipro ladipro added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label May 2, 2023
@AR-May AR-May added the triaged label Feb 21, 2024
@rainersigwald
Copy link
Member Author

The existing separate logging for Restore is ok IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Logging Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rainersigwald @ladipro @AR-May