Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LiveLogger] Use correct opt-in state #8431

Closed
donJoseLuis opened this issue Feb 9, 2023 · 3 comments
Closed

[LiveLogger] Use correct opt-in state #8431

donJoseLuis opened this issue Feb 9, 2023 · 3 comments
Assignees
@rainersigwald
Labels
Area: Logging Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged

Comments

@donJoseLuis
Copy link

Ensure LiveLogger has the right opt-in state to get the most modern logging including when combined with -bl
@donJoseLuis donJoseLuis mentioned this issue Feb 9, 2023
Open
28 tasks
@Forgind
Copy link
Member

Forgind commented Feb 23, 2023

I don't follow. Users have to opt in if they want to see the live logger at all; what more are you proposing?

@rainersigwald
Copy link
Member

This is specifically talking about things like calling IEventSource4.IncludeEvaluationPropertiesAndItems() so that we don't regress binlogs when this is enabled.

@ladipro ladipro added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label May 2, 2023
@rainersigwald rainersigwald self-assigned this Jun 13, 2023
@AR-May AR-May added the triaged label Feb 21, 2024
@rainersigwald
Copy link
Member

We do IncludeEvaluationPropertiesAndItems now, anything else we need we should treat as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rainersigwald rainersigwald

Labels
Area: Logging Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rainersigwald @ladipro @Forgind @donJoseLuis @AR-May