diff --git a/eng/build.ps1 b/eng/build.ps1 index 62ed98813db..e067a75d42c 100644 --- a/eng/build.ps1 +++ b/eng/build.ps1 @@ -162,7 +162,7 @@ function Check-RequiredVersionBumps() { git --no-pager diff --unified --no-color --exit-code -w origin/$env:SYSTEM_PULLREQUEST_TARGETBRANCH HEAD src\Framework\BuildEngineInterface.cs ` | Select-String -Pattern "int Version =" | ForEach-Object -process { $versionLineChanged = $true } if (($LASTEXITCODE -ne 0) -and (-not $versionLineChanged)) { - throw "##vso[task.logissue type=error] Detected changes in Framework\BuildEngineInterface.cs without a version bump. " + + throw "##vso[task.logissue type=error;sourcepath=src/Framework/BuildEngineInterface.cs] Detected changes in Framework\BuildEngineInterface.cs without a version bump. " + "If you are making API changes, please bump the version. " + "If the changes in the file are cosmetic, please add/change a comment on the Version prop to silence the error." } diff --git a/src/Build/BackEnd/Components/Logging/LoggingService.cs b/src/Build/BackEnd/Components/Logging/LoggingService.cs index 88145447f33..5d990e17586 100644 --- a/src/Build/BackEnd/Components/Logging/LoggingService.cs +++ b/src/Build/BackEnd/Components/Logging/LoggingService.cs @@ -1594,7 +1594,7 @@ private void UpdateMinimumMessageImportance(ILogger logger) // The null logger has no effect on minimum verbosity. Execution.BuildManager.NullLogger => null, - // If the logger is not on our whitelist, there are no importance guarantees. Fall back to "any importance". + // If the logger is not on our allowlist, there are no importance guarantees. Fall back to "any importance". _ => MessageImportance.Low }; diff --git a/src/MSBuild/OutOfProcTaskHostNode.cs b/src/MSBuild/OutOfProcTaskHostNode.cs index 6a8179e059b..79e942cec60 100644 --- a/src/MSBuild/OutOfProcTaskHostNode.cs +++ b/src/MSBuild/OutOfProcTaskHostNode.cs @@ -499,7 +499,7 @@ public void ReleaseCores(int coresToRelease) private sealed class BuildEngineInterfaceImpl : BuildEngineInterface { /// - /// No logging verbosity optimization in OOP nodes. + /// No logging verbosity optimization in TaskHost nodes. /// public override bool LogsMessagesOfImportance(MessageImportance importance) => true; }