From bdf6b18c82148f1039bad37bff99268a19ecfc95 Mon Sep 17 00:00:00 2001 From: Ladi Prosek Date: Mon, 2 Aug 2021 13:24:58 +0200 Subject: [PATCH] PR feedback: Comment distributed logger registration --- src/MSBuild/XMake.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/MSBuild/XMake.cs b/src/MSBuild/XMake.cs index ec59000bb87..3a62d532f86 100644 --- a/src/MSBuild/XMake.cs +++ b/src/MSBuild/XMake.cs @@ -3133,6 +3133,8 @@ private static void ProcessFileLoggers(string[][] groupedFileLoggerParameters, L LoggerVerbosity defaultFileLoggerVerbosity = LoggerVerbosity.Detailed; fileLogger.Verbosity = defaultFileLoggerVerbosity; + // Check to see if there is a possibility we will be logging from an out-of-proc node. + // If so (we're multi-proc or the in-proc node is disabled), we register a distributed logger. if (cpuCount == 1 && Environment.GetEnvironmentVariable("MSBUILDNOINPROCNODE") != "1") { // We've decided to use the MP logger even in single proc mode. @@ -3197,6 +3199,8 @@ List loggers consoleParameters = AggregateParameters(consoleParameters, consoleLoggerParameters); } + // Check to see if there is a possibility we will be logging from an out-of-proc node. + // If so (we're multi-proc or the in-proc node is disabled), we register a distributed logger. if (cpuCount == 1 && Environment.GetEnvironmentVariable("MSBUILDNOINPROCNODE") != "1") { // We've decided to use the MP logger even in single proc mode.