Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Accessible RadioButton #1002

Closed
rachelkang opened this issue May 10, 2021 · 1 comment · Fixed by #10832
Closed

[Enhancement] Accessible RadioButton #1002

rachelkang opened this issue May 10, 2021 · 1 comment · Fixed by #10832
Assignees
Labels
fixed-in-7.0.58 Look for this fix in 7.0.58! fixed-in-7.0.100 fixed-in-7.0.101 fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! legacy-area-a11y Relates to accessibility proposal/open s/a11y-researching t/a11y Relates to accessibility t/enhancement ☀️ New feature or request

Comments

@rachelkang
Copy link
Member

rachelkang commented May 10, 2021

Accessible RadioButton

The RadioButton has much room for improvement in their accessibility.

For starters, we need to:

  1. Improve accessibility of RadioButton, especially with ControlTemplate
  2. Make RadioButton accessible on iOS, where native equivalents do not exist

We must make them more accessible by ensuring they are both screen reader and keyboard navigable on all platforms.

Considerations

Although the area for improvement here is clear, the solution unfortunately is not. When making custom controls accessible, there are many considerations to be made.

  1. Improve accessibility of RadioButton, especially with ControlTemplate

This involves ensuring the buttons are just as accessible with or without the use of a ControlTemplate.
See the current radio button accessibility spike at A11yTools repo, where we begin to explore potential solutions

  1. Make RadioButton accessible on iOS, where native equivalents do not exist

Some of the options, thoughts, and questions that we're continuously thinking about:

  • If we try to mimic the behavior of RadioButtons as rendered on Safari and/or macOS, how can we approach that implementation? If anyone has any thoughts/advice about this, please do share!
  • Should we map it to a "similar" existing native control and have it "behave" like that control natively? (i.e. iOS UISwitch)
  • Should we assign our own custom accessibility text? If so, how do we determine that text? And how do we best translate/localize it?
  • What pieces of information are essential to announce for accessibility?
    • button content/text --> YES
    • "double to tap activate/check/switch" --> ?
    • "button 1 of 5" grouping info --> ??
    • etc --> ??
  • What should the screen reader read for these controls by default?

Related issues / PRs

@rachelkang rachelkang added the legacy-area-a11y Relates to accessibility label May 26, 2021
@rachelkang rachelkang changed the title [Enhancement] Accessible CheckBox and RadioButton [Enhancement] Accessible RadioButton Aug 16, 2021
@rachelkang rachelkang added this to the 6.0.300 milestone Apr 20, 2022
@PureWeen
Copy link
Member

Radiobutton traited like buttons with the selected trait and then the group label is prefixed

@PureWeen PureWeen removed their assignment Aug 3, 2022
@PureWeen PureWeen modified the milestones: 6.0.300, .NET 7 Planning Aug 3, 2022
@rachelkang rachelkang removed their assignment Aug 3, 2022
@rachelkang rachelkang self-assigned this Nov 23, 2022
@rachelkang rachelkang moved this to In Progress in MAUI SDK Ongoing Nov 23, 2022
Repository owner moved this from In Progress to Done in MAUI SDK Ongoing Nov 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 30, 2022
@samhouts samhouts added fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! fixed-in-7.0.58 Look for this fix in 7.0.58! labels Feb 23, 2023
@Eilon Eilon added the t/a11y Relates to accessibility label May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-7.0.58 Look for this fix in 7.0.58! fixed-in-7.0.100 fixed-in-7.0.101 fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! legacy-area-a11y Relates to accessibility proposal/open s/a11y-researching t/a11y Relates to accessibility t/enhancement ☀️ New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants