From d233998576d88c3c0d8b05280ef910c0c229661e Mon Sep 17 00:00:00 2001
From: Jeremi Kurdek <jkurdek@gmail.com>
Date: Thu, 23 May 2024 09:56:24 +0200
Subject: [PATCH] extracted binding id calculation into separate variable

---
 .../IntegrationTests.cs                       | 28 +++++++++++++------
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/src/Controls/tests/BindingSourceGen.UnitTests/IntegrationTests.cs b/src/Controls/tests/BindingSourceGen.UnitTests/IntegrationTests.cs
index cabebbc2cc41..4a77d1d4428e 100644
--- a/src/Controls/tests/BindingSourceGen.UnitTests/IntegrationTests.cs
+++ b/src/Controls/tests/BindingSourceGen.UnitTests/IntegrationTests.cs
@@ -14,6 +14,8 @@ public void GenerateSimpleBinding()
         """;
 
         var result = SourceGenHelpers.Run(source);
+        var id = Math.Abs(result.Binding!.Location.GetHashCode());
+
         AssertExtensions.AssertNoDiagnostics(result);
         AssertExtensions.CodeIsEqual(
             $$"""
@@ -39,7 +41,7 @@ internal static partial class GeneratedBindableObjectExtensions
             
                     {{BindingCodeWriter.GeneratedCodeAttribute}}
                     [InterceptsLocationAttribute(@"Path\To\Program.cs", 3, 7)]
-                    public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
+                    public static void SetBinding{{id}}(
                         this BindableObject bindableObject,
                         BindableProperty bindableProperty,
                         Func<string, int> getter,
@@ -107,6 +109,7 @@ public class B
         """;
 
         var result = SourceGenHelpers.Run(source);
+        var id = Math.Abs(result.Binding!.Location.GetHashCode());
         AssertExtensions.AssertNoDiagnostics(result);
         AssertExtensions.CodeIsEqual(
             $$"""
@@ -132,7 +135,7 @@ internal static partial class GeneratedBindableObjectExtensions
             
                     {{BindingCodeWriter.GeneratedCodeAttribute}}
                     [InterceptsLocationAttribute(@"Path\To\Program.cs", 6, 7)]
-                    public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
+                    public static void SetBinding{{id}}(
                         this BindableObject bindableObject,
                         BindableProperty bindableProperty,
                         Func<global::MyNamespace.A?, int> getter,
@@ -209,6 +212,7 @@ public class B
         """;
 
         var result = SourceGenHelpers.Run(source);
+        var id = Math.Abs(result.Binding!.Location.GetHashCode());
         AssertExtensions.AssertNoDiagnostics(result);
         AssertExtensions.CodeIsEqual(
             $$"""
@@ -234,7 +238,7 @@ internal static partial class GeneratedBindableObjectExtensions
             
                     {{BindingCodeWriter.GeneratedCodeAttribute}}
                     [InterceptsLocationAttribute(@"Path\To\Program.cs", 7, 7)]
-                    public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
+                    public static void SetBinding{{id}}(
                         this BindableObject bindableObject,
                         BindableProperty bindableProperty,
                         Func<global::MyNamespace.A?, int> getter,
@@ -416,6 +420,7 @@ public class C
     public void GenerateSimpleBindingWhenNullableDisabledAndPropertyNullable(string source)
     {
         var result = SourceGenHelpers.Run(source);
+        var id = Math.Abs(result.Binding!.Location.GetHashCode());
         AssertExtensions.AssertNoDiagnostics(result);
         AssertExtensions.CodeIsEqual(
             $$"""
@@ -441,7 +446,7 @@ internal static partial class GeneratedBindableObjectExtensions
             
                     {{BindingCodeWriter.GeneratedCodeAttribute}}
                     [InterceptsLocationAttribute(@"Path\To\Program.cs", 7, 7)]
-                    public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
+                    public static void SetBinding{{id}}(
                         this BindableObject bindableObject,
                         BindableProperty bindableProperty,
                         Func<global::MyNamespace.A?, global::MyNamespace.C?> getter,
@@ -532,6 +537,7 @@ public class D {
         """;
 
         var result = SourceGenHelpers.Run(source);
+        var id = Math.Abs(result.Binding!.Location.GetHashCode());
         AssertExtensions.AssertNoDiagnostics(result);
         AssertExtensions.CodeIsEqual(
             $$"""
@@ -557,7 +563,7 @@ internal static partial class GeneratedBindableObjectExtensions
             
                     {{BindingCodeWriter.GeneratedCodeAttribute}}
                     [InterceptsLocationAttribute(@"Path\To\Program.cs", 7, 7)]
-                    public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
+                    public static void SetBinding{{id}}(
                         this BindableObject bindableObject,
                         BindableProperty bindableProperty,
                         Func<global::MyNamespace.A?, global::MyNamespace.D?> getter,
@@ -648,6 +654,7 @@ public class MyPropertyClass
             """;
 
         var result = SourceGenHelpers.Run(source);
+        var id = Math.Abs(result.Binding!.Location.GetHashCode());
 
         AssertExtensions.AssertNoDiagnostics(result);
         AssertExtensions.CodeIsEqual(
@@ -674,7 +681,7 @@ internal static partial class GeneratedBindableObjectExtensions
 
                     {{BindingCodeWriter.GeneratedCodeAttribute}}
                     [InterceptsLocationAttribute(@"Path\To\Program.cs", 4, 7)]
-                    public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
+                    public static void SetBinding{{id}}(
                         this BindableObject bindableObject,
                         BindableProperty bindableProperty,
                         Func<global::MyNamespace.MySourceClass, global::MyNamespace.MyPropertyClass?> getter,
@@ -770,6 +777,7 @@ public class MyPropertyClass
             """;
 
         var result = SourceGenHelpers.Run(source);
+        var id = Math.Abs(result.Binding!.Location.GetHashCode());
 
         AssertExtensions.AssertNoDiagnostics(result);
         AssertExtensions.CodeIsEqual(
@@ -796,7 +804,7 @@ internal static partial class GeneratedBindableObjectExtensions
 
                     {{BindingCodeWriter.GeneratedCodeAttribute}}
                     [InterceptsLocationAttribute(@"Path\To\Program.cs", 4, 7)]
-                    public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
+                    public static void SetBinding{{id}}(
                         this BindableObject bindableObject,
                         BindableProperty bindableProperty,
                         Func<global::MyNamespace.MySourceClass, global::MyNamespace.MyPropertyClass> getter,
@@ -879,6 +887,7 @@ public class Wrapper
             """;
 
         var result = SourceGenHelpers.Run(source);
+        var id = Math.Abs(result.Binding!.Location.GetHashCode());
 
         AssertExtensions.AssertNoDiagnostics(result);
         AssertExtensions.CodeIsEqual(
@@ -904,7 +913,7 @@ internal static partial class GeneratedBindableObjectExtensions
                 {
                     {{BindingCodeWriter.GeneratedCodeAttribute}}
                     [InterceptsLocationAttribute(@"Path\To\Program.cs", 3, 7)]
-                    public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
+                    public static void SetBinding{{id}}(
                         this BindableObject bindableObject,
                         BindableProperty bindableProperty,
                         Func<global::MyNamespace.A, int> getter,
@@ -984,6 +993,7 @@ public class MyPropertyClass
             """;
 
         var result = SourceGenHelpers.Run(source);
+        var id = Math.Abs(result.Binding!.Location.GetHashCode());
 
         AssertExtensions.AssertNoDiagnostics(result);
         AssertExtensions.CodeIsEqual(
@@ -1010,7 +1020,7 @@ internal static partial class GeneratedBindableObjectExtensions
 
                     {{BindingCodeWriter.GeneratedCodeAttribute}}
                     [InterceptsLocationAttribute(@"Path\To\Program.cs", 6, 7)]
-                    public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
+                    public static void SetBinding{{id}}(
                         this BindableObject bindableObject,
                         BindableProperty bindableProperty,
                         Func<global::MyNamespace.MySourceClass, global::MyNamespace.MyPropertyClass?> getter,