Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Use Mono.Cecil from NuGet. #5507

Closed
rolfbjarne opened this issue Jan 29, 2019 · 2 comments
Closed

[RFC] Use Mono.Cecil from NuGet. #5507

rolfbjarne opened this issue Jan 29, 2019 · 2 comments
Labels
enhancement The issue or pull request is an enhancement iOS Issues affecting iOS macOS Issues affecting macOS request-for-comments The issue is a suggested idea seeking feedback
Milestone
Future

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented Jan 29, 2019 •
edited
Loading

Proposal:

  • Consume Mono.Cecil from NuGet instead of the source code from mono's submodule (external/mono/external/cecil).

Problems it solves:

Current cecil source consumers:

$ git grep ProjectReference.*Mono.Cecil.csproj
tests/mtouch/mtouch.csproj:    <ProjectReference Include="..\..\external\mono\external\cecil\Mono.Cecil.csproj">
tools/mmp/mmp.csproj:    <ProjectReference Include="..\..\external\mono\external\cecil\Mono.Cecil.csproj">
tools/mtouch/mtouch.csproj:    <ProjectReference Include="..\..\external\mono\external\cecil\Mono.Cecil.csproj">
@rolfbjarne rolfbjarne added enhancement The issue or pull request is an enhancement macOS Issues affecting macOS iOS Issues affecting iOS request-for-comments The issue is a suggested idea seeking feedback labels Jan 29, 2019
@rolfbjarne rolfbjarne added this to the Future milestone Jan 29, 2019
@rolfbjarne rolfbjarne changed the title Use Mono.Cecil from NuGet. [RFC] Use Mono.Cecil from NuGet. Jan 29, 2019
@spouliot
Copy link
Contributor

The cecil revision is currently harmonized (RE) across all products (IDE/SDK) to avoid different bugs/fixes. That could also be done using nugets but it needs to be raised outside the team.

@rolfbjarne
Copy link
Member Author

This was implemented with the mono archive.

@ghost ghost locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement The issue or pull request is an enhancement iOS Issues affecting iOS macOS Issues affecting macOS request-for-comments The issue is a suggested idea seeking feedback
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@rolfbjarne @spouliot