Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAOT: Investigate whether we can narrow down the list of assemblies to look for UnmanagedCallersOnly entry points #18484

Open
Tracked by #80905
rolfbjarne opened this issue Jun 21, 2023 · 2 comments
Assignees
Labels
enhancement The issue or pull request is an enhancement
Milestone

Comments

@rolfbjarne
Copy link
Member

Ref: #17374 (comment)

We currently look for UnmanagedCallersOnly entry points in all assemblies:

<!-- Process UnmanagedCallersOnly attributes from every assembly -->
<UnmanagedEntryPointsAssembly Remove="System.Private.CoreLib" />
<UnmanagedEntryPointsAssembly Include="@(_UpdatedManagedAssemblyToLink->'%(Filename)')" />

We must to do this for all assemblies we've modified using the managed static registrar, but it might not be necessary for any other assemblies.

So we need to look into whether we can shrink this list of assemblies.

@jkurdek
Copy link
Member

jkurdek commented Jan 9, 2024

@ivanpovazan I would like to pick this up

@github-project-automation github-project-automation bot moved this to NativeAOT in .NET 9 Aug 27, 2024
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 27, 2024
@rolfbjarne rolfbjarne removed this from .NET 9 Sep 27, 2024
@MichalStrehovsky
Copy link
Member

This was hit in dotnet/runtime#110608. It would be nice to do something about this. Generating this for random assemblies risks running into issues described in dotnet/docs#39362 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Development

No branches or pull requests

3 participants