Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General AddBoundValue fixes, test coverage, and slight API change #9234

Merged
merged 7 commits into from
May 20, 2020
Merged

General AddBoundValue fixes, test coverage, and slight API change #9234

merged 7 commits into from
May 20, 2020

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented May 20, 2020

  • Fixes an issue with importing reflection types.
  • AddBoundValue does not return errors and instead will only throw exceptions.
  • More test coverage, such as types from dynamic assemblies and non-public types.

@jonsequitur @colombod

@KevinRansom KevinRansom merged commit 348ed06 into dotnet:master May 20, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@TIHan @nosami
General AddBoundValue fixes, test coverage, and slight API change (do…
c66f623 
…tnet#9234)

* Changed AddBoundValue API to throw exceptions instead of returning error list.

* Fixed generic types with AddBoundValue

* Added failing test

* Added more tests

* Added function tests

* Special case functions even more

* Minor name change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colombod colombod colombod approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TIHan @colombod @KevinRansom