Remove blocking members from FSharpDeclarationListItem #9187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
reviewed
May 14, 2020
| @@ -183,7 +183,7 @@ type internal FSharpDeclarations_DEPRECATED(documentationBuilder, declarations: | |||
| let decls = trimmedDeclarations filterText | |||
| if (index >= 0 && index < decls.Length) then | |||
| let buf = Text.StringBuilder() | |||
| XmlDocumentation.BuildDataTipText_DEPRECATED(documentationBuilder, TaggedText.appendTo buf, TaggedText.appendTo buf, decls.[index].StructuredDescriptionText) | |||
| XmlDocumentation.BuildDataTipText_DEPRECATED(documentationBuilder, TaggedText.appendTo buf, TaggedText.appendTo buf, decls.[index].StructuredDescriptionTextAsync |> Async.RunSynchronously) | |||
There was a problem hiding this comment.
so the usage is only in FSharpDeclarations_DEPRECATED - which was deprecated 2017 ;-)
|
@TIHan pls approve |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asynchronous versions of these members are what are used in tools. These legacy members will just block on the caller for up to 5 seconds which is madness. Also removed all the comments about this, since those stem from at least F# 3.0 days and refer to behavior in Visual Studio that has long since been outdated (at least since VS 2017 when we replaced the language service host, and certainly in VS 2019 when all completion was made asynchronous by default). No editor tooling should be calling these members.