Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the LanguageServiceProfiling project #9183

Merged
merged 1 commit into from
May 13, 2020
Merged

Remove the LanguageServiceProfiling project #9183

merged 1 commit into from
May 13, 2020

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented May 13, 2020 •
edited
Loading

This project:

  • Doesn't run by default
  • Doesn't actually profile much, and there's no usage of any statistical benchmarking tools
  • Looks like some artifact of an older time when performance wasn't as well-understood as it is these days

I think it's better to just remove it so we don't give the impression that this is a useful tool for profiling the language service

@cartermp cartermp merged commit fe7c56a into dotnet:master May 13, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@cartermp @nosami
Remove the LanguageServiceProfiling project (dotnet#9183)
2537096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettfo brettfo brettfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cartermp @brettfo