Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include FSharp.Core.xml in the dotnet SDK #9015

Merged
merged 1 commit into from
Apr 21, 2020
Merged

include FSharp.Core.xml in the dotnet SDK #9015

merged 1 commit into from
Apr 21, 2020

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Apr 21, 2020

Fixes #8808.

@brettfo brettfo requested review from KevinRansom and cartermp April 21, 2020 22:09
@baronfel
Copy link
Member

You two are the best, thanks for getting this in.

@cartermp
Copy link
Contributor

You can thank @Krzysztof-Cieslak for the nerd sniping 🙂

@brettfo brettfo merged commit 1d43a19 into dotnet:master Apr 21, 2020
@brettfo brettfo deleted the sdk-xml branch April 21, 2020 23:02
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@brettfo @nosami
include FSharp.Core.xml in the dotnet SDK (dotnet#9015)
ad9d2aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing xml documentation for FSharp.Core in SDK deployables
4 participants
@brettfo @baronfel @cartermp @KevinRansom