Merge main to feature/nullness #17304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* port fsih to fsi as a hash directive * add PR number * update xlf files * update core printing baselines * rename module to FsiHelp * rewrite Help.Print() to return a string to be independent of FsiConsoleOutput. * move fsihelp module to dedicated file * use shims for the filesystem * - Use fsi.h as an user interface. Unfortunately, we lose access to the shimed filesystem by being in the FSharp.Compiler.Interactive.Settings project. * use a fsi printer for nicer output * update baselines * remove suppressItPrint parameter * Update src/FSharp.Compiler.Interactive.Settings/fsihelp.fs Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Update src/FSharp.Compiler.Interactive.Settings/fsihelp.fs Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * use voption to let the printer work in the (v)none case * format * remove doubled assembly attributes * refactor * add some tests * - let xpath queries work with single quotes in names like "shouldn't" - add tests * Trigger Build * adjust changelog entry * move back to #h interface * rename tryGetDocumentation to tryGetHelp * use #help "expr";; * append a newline if we don't find docs to position cursor correctly * format * adjust release notes again * update surfacearea baselines * adjust help text to use "identifier" instead of "expression" * add unit test for non-identifier to show unhappy path * add bsl entries for help output inside of fsi * update line numbers in bsl files * update line numbers in err bsl files --------- Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Crossgen2 is not built with Mono-based .NET SDKs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from main into feature/nullness.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout -t upstream/merges/main-to-feature/nullness git reset --hard upstream/feature/nullness git merge upstream/main # Fix merge conflicts git commit git push upstream merges/main-to-feature/nullness --force