Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues for plain 'dotnet build Fsharp.Compiler.Service.sln` #17185

Merged
merged 3 commits into from
May 21, 2024
Merged

Fix issues for plain 'dotnet build Fsharp.Compiler.Service.sln` #17185

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7da45b5
fix issues for plain 'dotnet build Fsharp.Compiler.Service.sln`
T-Gro May 20, 2024
c28b21a
update FSharpCoreShippedPackageVersionValue
T-Gro May 20, 2024
3570b2f
Wkraround attributetargets issue by using 'obj'. This removes 3x box …
T-Gro May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,3 +127,4 @@ nCrunchTemp_*
tests/FSharp.Compiler.Service.Tests/FSharp.CompilerService.SurfaceArea.netstandard.actual
*.vsp
/tests/AheadOfTime/Trimming/output.txt
*.svclog
1 change: 0 additions & 1 deletion src/Compiler/Service/SemanticClassification.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ type SemanticClassificationType =
| TypeDef = 35
| Plaintext = 36

[<RequireQualifiedAccess>]
[<Struct>]
type SemanticClassificationItem =
val Range: range
Expand Down
1 change: 0 additions & 1 deletion src/Compiler/Service/SemanticClassification.fsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ type SemanticClassificationType =
| TypeDef = 35
| Plaintext = 36

[<RequireQualifiedAccess>]
[<Struct>]
type SemanticClassificationItem =
val Range: range
Expand Down
2 changes: 1 addition & 1 deletion src/Compiler/TypedTree/TypedTreeOps.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3515,7 +3515,7 @@ let TryFindLocalizedFSharpStringAttribute g nm attrs =
| Some(Attrib(_, _, [ AttribStringArg b ], namedArgs, _, _, _)) ->
match namedArgs with
| ExtractAttribNamedArg "Localize" (AttribBoolArg true) ->
#if PROTO
#if PROTO || BUILDING_WITH_LKG
Some b
#else
FSComp.SR.GetTextOpt(b)
Expand Down
2 changes: 2 additions & 0 deletions src/Compiler/Utilities/illib.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

namespace Internal.Utilities.Library

#nowarn "842" //This attribute is not valid for use on this language element for `valueFactory` below

open System
open System.Collections.Generic
open System.Collections.Concurrent
Expand Down
1 change: 0 additions & 1 deletion tests/service/data/TestTP/ProvidedTypes.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3220,7 +3220,6 @@ module internal AssemblyReader =
systemRuntimeScopeRef: ILScopeRef }
override __.ToString() = "<ILGlobals>"

[<AutoOpen>]
[<Struct>]
type ILTableName(idx: int) =
member __.Index = idx
Expand Down
Loading