Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion: fix for unfinished record field decl #16893

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Completion: fix for unfinished record field decl #16893

merged 4 commits into from
Mar 19, 2024

Conversation

auduchinok
Copy link
Member

Fixes broken completion on empty prefix in record declarations:

type Record =
    { Field: {caret} }

@auduchinok auduchinok requested a review from a team as a code owner March 18, 2024 15:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

psfinaki
psfinaki approved these changes Mar 18, 2024
View reviewed changes
@psfinaki psfinaki enabled auto-merge (squash) March 18, 2024 18:45
@psfinaki psfinaki merged commit b353688 into dotnet:main Mar 19, 2024
32 checks passed
@auduchinok auduchinok deleted the completion-recdDefn2 branch March 19, 2024 15:03
@dotnet-bot dotnet-bot mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@auduchinok @psfinaki @edgarfgp @T-Gro