Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TransparentCompiler cache for GetProjectOptionsFromScript #16889

Merged

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 18, 2024

Description

This invokes the GetProjectSnapshotFromScript call from GetProjectOptionsFromScript so the load script closure is properly cached in the Transparent Compiler.

@0101 I've exposed the item count from AsyncMemoize, this seems slightly more convenient than the event route. I don't have a strong preference on this, so let me know if you wish to see this differently.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@nojaf nojaf requested a review from a team as a code owner March 18, 2024 12:55
@nojaf nojaf added Transparent-Compiler NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes labels Mar 18, 2024
Copy link
Contributor

github-actions bot commented Mar 18, 2024

❗ Release notes required

@nojaf,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md No release notes found or release notes format is not correct

@T-Gro T-Gro enabled auto-merge (squash) March 18, 2024 15:01
@T-Gro T-Gro merged commit dc78363 into dotnet:main Mar 18, 2024
32 of 34 checks passed
nojaf added a commit to nojaf/fsharp that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes Transparent-Compiler
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants