Update SourceBuild.props #16780
Merged
Update SourceBuild.props #16780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Condition targets that change what to build based on the source-build flags so that when building the repository inside the VMR for unified-build, we build everything and don't bootstrap.
✅ No release notes required |
oleksandr-didyk
approved these changes
Feb 28, 2024
vzarytovskii
approved these changes
Feb 28, 2024
mthalman
reviewed
Feb 28, 2024
| <Target Name="ConfigureInnerBuildArg" BeforeTargets="GetSourceBuildCommandConfiguration"> | ||
| <Target Name="ConfigureInnerBuildArg" | ||
| BeforeTargets="GetSourceBuildCommandConfiguration" | ||
| Condition="'$(ArcadeBuildFromSource)' == 'true' or '$(DotNetBuildSourceOnly)' == 'true'"> |
There was a problem hiding this comment.
Shouldn't this entire props file be conditionally imported based on this condition instead?
There was a problem hiding this comment.
You mean SourceBuild.props? No, we always import that, unconditionally. There's no hook today that would allow that: https://github.com/dotnet/arcade/blob/9aa3f2e68b30ac51823dd444e8cb962e058c5699/src/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/SourceBuildArcade.targets#L17-L20
I doubt it would be worthwhile to conditionally import this file based on the build mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#4029
Condition targets that change what to build based on the source-build flags so that when building the repository inside the VMR for unified-build, we build everything and don't bootstrap.