Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to properly use [<Fact>] AttributeTargets.Method #16610

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Jan 30, 2024

Description

  [AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
  public class FactAttribute : Attribute

[<Fact>] enforces the use of this attribute only on methods which currently the compiler fails to do it. So this PR just updates some CompletionProviderTests to properly use this.

This was found while working on #16128

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@edgarfgp edgarfgp requested a review from a team as a code owner January 30, 2024 09:36
@edgarfgp edgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jan 30, 2024
Copy link
Contributor

github-actions bot commented Jan 30, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@edgarfgp edgarfgp changed the title Update tests to properly [<Fact>] AttributeTargets.Method Update tests to properly use [<Fact>] AttributeTargets.Method Jan 30, 2024
@T-Gro T-Gro enabled auto-merge (squash) January 30, 2024 10:12
@T-Gro T-Gro merged commit 2f3ed21 into dotnet:main Jan 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants