Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up unused opens handling for empty results #16502

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Speed up unused opens handling for empty results #16502

merged 2 commits into from
Jan 8, 2024

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Jan 8, 2024

Before:

BenchmarkDotNet=v0.13.2, OS=Windows 11 (10.0.22621.2861)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK=8.0.100
  [Host]     : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2 DEBUG
  DefaultJob : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2
Method Mean Error StdDev Median Gen0 Allocated
UnusedOpens 924.6 us 41.93 us 119.0 us 889.5 us 11.7188 747.91 KB

After:

BenchmarkDotNet=v0.13.2, OS=Windows 11 (10.0.22621.2861)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK=8.0.100
  [Host]     : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2 DEBUG
  DefaultJob : .NET 8.0.0 (8.0.23.53103), X64 RyuJIT AVX2
Method Mean Error StdDev Gen0 Allocated
UnusedOpens 80.31 us 1.602 us 2.348 us 0.6104 43.21 KB

@psfinaki psfinaki requested a review from a team as a code owner January 8, 2024 15:18
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.200.md

@psfinaki psfinaki enabled auto-merge (squash) January 8, 2024 16:31
@psfinaki psfinaki merged commit 63cb950 into main Jan 8, 2024
27 checks passed
@psfinaki psfinaki deleted the bench/9 branch January 8, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants