Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facelifting compiled code benchmarks #16485

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Facelifting compiled code benchmarks #16485

merged 1 commit into from
Jan 4, 2024

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Jan 3, 2024

This does some cleanup in the tests/benchmarks/CompiledCodeBenchmarks folder:

  • fixes the compile error in MicroPerf.fsproj - the project lost the dependency in this PR
  • removes the NU1505 workarounds - those were added here but looks like in the meantime the original problem was fixed, the VisualFSharp.sln compiles just fine without the hack now
  • migrates one of the projects from .NET7 to .NET8 - was forgotten to be done in this PR
  • consolidates BDN dep in some places
  • removes a bunch of commented code

@psfinaki psfinaki requested a review from a team as a code owner January 3, 2024 17:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

✅ No release notes required

@T-Gro T-Gro merged commit 8f67320 into main Jan 4, 2024
27 checks passed
@T-Gro T-Gro deleted the bench/4 branch January 4, 2024 09:44
@psfinaki psfinaki mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonie abonie abonie approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psfinaki @abonie @T-Gro